From: Krzysztof Kozlowski <krzk@kernel.org>
To: Jan Kandziora <jjj@gmx.de>, Maoyi Xie <maoyixie.tju@gmail.com>
Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>,
Andi Shyti <andi.shyti@kernel.org>,
Bjorn Andersson <bjorn.andersson@oss.qualcomm.com>,
linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] w1: ds28e17: reject an oversize length on an I2C block read
Date: Fri, 03 Jul 2026 11:45:48 +0200 [thread overview]
Message-ID: <178307194894.60311.427647800864172952.b4-ty@b4> (raw)
In-Reply-To: <20260629121043.199487-1-maoyixie.tju@gmail.com>
On Mon, 29 Jun 2026 20:10:43 +0800, Maoyi Xie wrote:
> w1_f19_i2c_master_transfer() is the master_xfer for the DS28E17 1-Wire
> to I2C bridge. On an I2C_M_RECV_LEN read, it takes the length from the
> device. The downstream slave puts a length byte in buf[0]. The driver
> then reads that many bytes into buf[1] with w1_f19_i2c_read().
>
> buf[0] is controlled by the device and can be 0 to 255.
> w1_f19_i2c_read() only rejects a zero count. The caller buffer is
> I2C_SMBUS_BLOCK_MAX + 2, so 34 bytes. A length above 32 makes the read
> run past it, up to about 222 bytes out of bounds.
>
> [...]
Applied, thanks!
[1/1] w1: ds28e17: reject an oversize length on an I2C block read
https://git.kernel.org/krzk/linux-w1/c/487eca6535cab91944ade06a155e9d789591a1e5
Best regards,
--
Krzysztof Kozlowski <krzk@kernel.org>
prev parent reply other threads:[~2026-07-03 9:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-29 12:10 Maoyi Xie
2026-07-02 16:38 ` Andi Shyti
2026-07-02 16:41 ` Krzysztof Kozlowski
2026-07-02 19:07 ` Andi Shyti
2026-07-03 9:45 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=178307194894.60311.427647800864172952.b4-ty@b4 \
--to=krzk@kernel.org \
--cc=andi.shyti@kernel.org \
--cc=bjorn.andersson@oss.qualcomm.com \
--cc=jjj@gmx.de \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maoyixie.tju@gmail.com \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox