From: "tip-bot2 for Radu Rendec" <tip-bot2@linutronix.de>
To: linux-tip-commits@vger.kernel.org
Cc: Radu Rendec <radu@rendec.net>, Thomas Gleixner <tglx@kernel.org>,
x86@kernel.org, linux-kernel@vger.kernel.org, maz@kernel.org
Subject: [tip: irq/core] parisc: Remove unnecessary NULL check of the kstat_irqs field
Date: Tue, 07 Jul 2026 19:38:58 -0000 [thread overview]
Message-ID: <178345313898.744054.8164416070801504610.tip-bot2@tip-bot2> (raw)
In-Reply-To: <20260705210951.2717741-3-radu@rendec.net>
The following commit has been merged into the irq/core branch of tip:
Commit-ID: 2c27d9b154743eb113e643680b5ce2f8a51647a4
Gitweb: https://git.kernel.org/tip/2c27d9b154743eb113e643680b5ce2f8a51647a4
Author: Radu Rendec <radu@rendec.net>
AuthorDate: Sun, 05 Jul 2026 17:09:51 -04:00
Committer: Thomas Gleixner <tglx@kernel.org>
CommitterDate: Tue, 07 Jul 2026 21:36:19 +02:00
parisc: Remove unnecessary NULL check of the kstat_irqs field
The kstat_irqs field of struct irq_desc is used to store a per-cpu count
of interrupt events. It is initialized in init_desc(), along with all
the other fields in struct irq_desc that need explicit initialization,
and therefore it's always available (non-NULL) for any valid interrupt
descriptor.
On parisc, CONFIG_SPARSE_IRQ is disabled, interrupt descriptors are
allocated statically in the irq_desc[] array, and kstat_irqs is
initialized implicitly to NULL. The kstat_irqs field is initialized
later, for all descriptors, via start_kernel() -> early_irq_init() ->
init_desc().
smp_boot_one_cpu() is used only for CPU hotplugging. On a SMP system,
the boot CPU initializes the interrupt descriptors as described above,
and smp_boot_one_cpu() is called later, for the secondary CPU(s).
A previous change made similar changes across the generic interrupt code in
kernel/irq/irqdesc.c, and provides a more detailed explanation of why
kstat_irqs is guaranteed to be non-NULL.
Signed-off-by: Radu Rendec <radu@rendec.net>
Signed-off-by: Thomas Gleixner <tglx@kernel.org>
Link: https://patch.msgid.link/20260705210951.2717741-3-radu@rendec.net
---
arch/parisc/kernel/smp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/parisc/kernel/smp.c b/arch/parisc/kernel/smp.c
index b2d12ab..36be17e 100644
--- a/arch/parisc/kernel/smp.c
+++ b/arch/parisc/kernel/smp.c
@@ -343,7 +343,7 @@ static int smp_boot_one_cpu(int cpuid, struct task_struct *idle)
for (i = 0; i < NR_IRQS; i++) {
struct irq_desc *desc = irq_to_desc(i);
- if (desc && desc->kstat_irqs)
+ if (desc)
*per_cpu_ptr(desc->kstat_irqs, cpuid) = (struct irqstat) { };
}
#endif
next prev parent reply other threads:[~2026-07-07 19:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-05 21:09 [PATCH 0/2] " Radu Rendec
2026-07-05 21:09 ` [PATCH 1/2] genirq: " Radu Rendec
2026-07-07 19:39 ` [tip: irq/core] " tip-bot2 for Radu Rendec
2026-07-05 21:09 ` [PATCH 2/2] parisc: " Radu Rendec
2026-07-07 19:38 ` tip-bot2 for Radu Rendec [this message]
2026-07-25 20:04 ` Helge Deller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=178345313898.744054.8164416070801504610.tip-bot2@tip-bot2 \
--to=tip-bot2@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=maz@kernel.org \
--cc=radu@rendec.net \
--cc=tglx@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®