mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "tip-bot2 for Thomas Weißschuh" <tip-bot2@linutronix.de>
To: linux-tip-commits@vger.kernel.org
Cc: thomas.weissschuh@linutronix.de,
	Thomas Gleixner <tglx@kernel.org>,
	philmd@oss.qualcomm.com, Arnd Bergmann <arnd@arndb.de>,
	x86@kernel.org, linux-kernel@vger.kernel.org
Subject: [tip: timers/vdso] vdso/gettimeofday: Validate system call existence for time() and gettimeofday()
Date: Tue, 07 Jul 2026 21:54:47 -0000	[thread overview]
Message-ID: <178346128721.744054.12737676507240764648.tip-bot2@tip-bot2> (raw)
In-Reply-To: <20260702-vdso-compat_32bit_time-v3-2-db9f36d8d432@linutronix.de>

The following commit has been merged into the timers/vdso branch of tip:

Commit-ID:     f8b946772554ea11380fe03fc446376794a81a36
Gitweb:        https://git.kernel.org/tip/f8b946772554ea11380fe03fc446376794a81a36
Author:        Thomas Weißschuh <thomas.weissschuh@linutronix.de>
AuthorDate:    Thu, 02 Jul 2026 10:21:26 +02:00
Committer:     Thomas Gleixner <tglx@kernel.org>
CommitterDate: Tue, 07 Jul 2026 23:52:53 +02:00

vdso/gettimeofday: Validate system call existence for time() and gettimeofday()

Not all architectures have the system calls for time() and
gettimeofday(). When the system call is missing, the vDSO function
should also not be present.

Validate that.

Signed-off-by: Thomas Weißschuh <thomas.weissschuh@linutronix.de>
Signed-off-by: Thomas Gleixner <tglx@kernel.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@oss.qualcomm.com>
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
Link: https://patch.msgid.link/20260702-vdso-compat_32bit_time-v3-2-db9f36d8d432@linutronix.de
---
 lib/vdso/gettimeofday.c | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/lib/vdso/gettimeofday.c b/lib/vdso/gettimeofday.c
index e0f289d..b8c1fc8 100644
--- a/lib/vdso/gettimeofday.c
+++ b/lib/vdso/gettimeofday.c
@@ -12,6 +12,8 @@
 #include <vdso/time32.h>
 #include <vdso/time64.h>
 
+#include <uapi/linux/unistd.h>
+
 /*
  * The generic vDSO implementation requires that gettimeofday.h
  * provides:
@@ -348,6 +350,10 @@ __cvdso_gettimeofday_data(const struct vdso_time_data *vd,
 {
 	const struct vdso_clock *vc = vd->clock_data;
 
+#ifndef __NR_gettimeofday
+	BUILD_BUG();
+#endif
+
 	if (likely(tv != NULL)) {
 		struct __kernel_timespec ts;
 
@@ -382,6 +388,10 @@ __cvdso_time_data(const struct vdso_time_data *vd, __kernel_old_time_t *time)
 	const struct vdso_clock *vc = vd->clock_data;
 	__kernel_old_time_t t;
 
+#ifndef __NR_time
+	BUILD_BUG();
+#endif
+
 	if (vdso_is_timens_clock(vc)) {
 		vd = vdso_timens_data(vd);
 		vc = vd->clock_data;

  reply	other threads:[~2026-07-07 21:54 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-02  8:21 [PATCH v3 0/9] vDSO: Respect COMPAT_32BIT_TIME Thomas Weißschuh
2026-07-02  8:21 ` [PATCH v3 1/9] time: Respect COMPAT_32BIT_TIME for old time type functions Thomas Weißschuh
2026-07-07 21:54   ` [tip: timers/vdso] " tip-bot2 for Thomas Weißschuh
2026-07-02  8:21 ` [PATCH v3 2/9] vdso/gettimeofday: Validate system call existence for time() and gettimeofday() Thomas Weißschuh
2026-07-07 21:54   ` tip-bot2 for Thomas Weißschuh [this message]
2026-07-02  8:21 ` [PATCH v3 3/9] x86/vdso: Respect COMPAT_32BIT_TIME Thomas Weißschuh
2026-07-07 21:54   ` [tip: timers/vdso] " tip-bot2 for Thomas Weißschuh
2026-07-02  8:21 ` [PATCH v3 4/9] arm64: vdso32: " Thomas Weißschuh
2026-07-07 21:54   ` [tip: timers/vdso] " tip-bot2 for Thomas Weißschuh
2026-07-02  8:21 ` [PATCH v3 5/9] ARM: VDSO: " Thomas Weißschuh
2026-07-07 21:54   ` [tip: timers/vdso] " tip-bot2 for Thomas Weißschuh
2026-07-02  8:21 ` [PATCH v3 6/9] powerpc/vdso: " Thomas Weißschuh
2026-07-07 21:54   ` [tip: timers/vdso] " tip-bot2 for Thomas Weißschuh
2026-07-02  8:21 ` [PATCH v3 7/9] MIPS: VDSO: " Thomas Weißschuh
2026-07-07 21:54   ` [tip: timers/vdso] " tip-bot2 for Thomas Weißschuh
2026-07-02  8:21 ` [PATCH v3 8/9] sparc: vdso: " Thomas Weißschuh
2026-07-07 21:54   ` [tip: timers/vdso] " tip-bot2 for Thomas Weißschuh
2026-07-02  8:21 ` [PATCH v3 9/9] vdso/gettimeofday: Verify COMPAT_32BIT_TIME interactions Thomas Weißschuh
2026-07-07 21:54   ` [tip: timers/vdso] " tip-bot2 for Thomas Weißschuh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=178346128721.744054.12737676507240764648.tip-bot2@tip-bot2 \
    --to=tip-bot2@linutronix.de \
    --cc=arnd@arndb.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=philmd@oss.qualcomm.com \
    --cc=tglx@kernel.org \
    --cc=thomas.weissschuh@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®