From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1756563AbbI1HgC (ORCPT <rfc822;w@1wt.eu>);
	Mon, 28 Sep 2015 03:36:02 -0400
Received: from mout.kundenserver.de ([212.227.17.10]:65276 "EHLO
	mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750864AbbI1HgA (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 28 Sep 2015 03:36:00 -0400
From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: Zhen Lei <thunder.leizhen@huawei.com>,
        Catalin Marinas <catalin.marinas@arm.com>,
        Will Deacon <will.deacon@arm.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        Kefeng Wang <wangkefeng.wang@huawei.com>,
        Xinwei Hu <huxinwei@huawei.com>, Zefan Li <lizefan@huawei.com>,
        Tianhong Ding <dingtianhong@huawei.com>,
        Hanjun Guo <guohanjun@huawei.com>
Subject: Re: [PATCH 2/2] arm64: to allow EFI_RTC can be selected on ARM64
Date: Mon, 28 Sep 2015 09:35:50 +0200
Message-ID: <1783631.jH4WY2RqXu@wuerfel>
User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; )
In-Reply-To: <1443418478-8240-3-git-send-email-thunder.leizhen@huawei.com>
References: <1443418478-8240-1-git-send-email-thunder.leizhen@huawei.com> <1443418478-8240-3-git-send-email-thunder.leizhen@huawei.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Provags-ID: V03:K0:KNOoJ1vnlJokVrB9UHu7xg1OxAl/CpseyJCJtY76Vqe29W7Q/GY
 9SA2gVVAefU46Rom6mqguOnw5uut5+f0UB/2ut5lB7CrGBq+eRgxDO9N+1A7y0qPNpaMb0K
 rAWlt2GqvkBblI+7wT9E3sCeGlq7QsTb3ibknBs9UuCLvwDCc0opT7HmgUHYRs+Uaie7Vr0
 M7phl98Dr3AvI1oRPewoA==
X-UI-Out-Filterresults: notjunk:1;V01:K0:ioJIykkExbE=:miAxVrL0fS83GDHCGBLANu
 UdclRlgweRfj8SN8E0dQjnz23p2MhzDilXvWw+V67kq8yGrEZwUDm2EGT2/BR842v2fJGu83+
 XFZ2MMKmFa9x6xOHwawScQFyPCMDPf5NvbhQyrw481FaG62QR4vRnJ8WJ8ChtedlGCuwwL/FE
 T2wxvr0lUFQnirwLo6/m5JFqQN1V7eyxNoPRvMv+MEkeVtkk/Ab//0OUwD1R8JkfexVaS4HQa
 8W5W3hNUKnSDXfMUIQ5kb5BdgDgFnPJF7Ld8Oo72ga+T+WxsQrN9I4ahuliIzaNBCUkvBcQGF
 +q3ZadMrEB4oIETelK1MO2U4qXssXk1e9FBAXP7jTrhjVckiGF/eSlPPpJio/Sm/rVDxN3Kbf
 5DZ0r+r7w7kOnMW5FHVAFBygQsdHxP6tR5jTG+BJt0RAS9vt2VWREveRUre3PRMiXeDgGRb24
 qT1dusEaaCmiIK3HQ5eLiyg9Om2Qf3Aw0ZFeIhmg7g/TRCLgXTTi8rr9jI1y32fASu706MkK+
 CotLurtPWWcCpMjkR21EXQ1B2b2XqI90BSQAufDVKcZ3VoA/ywTalu9paUsHEzVDviY55DtPq
 HgVsjDK1qio0E/4XgxGETPdDaZrUWdWOXuV1VbU5gixYHcFFWiUeOQTAuw2/x87aZBWMFbQGW
 Tti9XCa7w7YdL1V3MDvGBcnzGz7qoS/iowFl2tXEFRwrTBs6VO1fsl6Ems+MVgDA+jk8dcwRD
 tT/67BSh102x0NBe
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Monday 28 September 2015 13:34:38 Zhen Lei wrote:
> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
> index 07d1811..25cec57 100644
> --- a/arch/arm64/Kconfig
> +++ b/arch/arm64/Kconfig
> @@ -85,7 +85,7 @@ config ARM64
>         select PERF_USE_VMALLOC
>         select POWER_RESET
>         select POWER_SUPPLY
> -       select RTC_LIB
> +       select RTC_LIB if !EFI
>         select SPARSE_IRQ
>         select SYSCTL_EXCEPTION_TRACE
>         select HAVE_CONTEXT_TRACKING

Sorry, we can't do that: enabling EFI has to be done in a way that it only
adds features but not disables them.

Your patch breaks RTC on all non-EFI platforms as soon as CONFIG_EFI
is selected by the user.

	Arnd