From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 178FC37B00C; Fri, 10 Jul 2026 18:07:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783706847; cv=none; b=AcHHs/YfAhFJ+7k1qNSIx2WLb9awzFk5uMvpkK6JBcuFqLmLuqtqHbBh4LxadC7xdva00IUPhgsHRFp/vRHLndtvjCbotPbT8ER15BrkWib1WNfTwG0dEjcVVGfpZetRZAM6YeAqsRnk9zLUm6Pg3NTw5pmomFwc64u/yRmu3DI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783706847; c=relaxed/simple; bh=aGN9UFD3p475WZ6QXcEiVRxsI4VaSpdbdcP+8eMNjsE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=VKXDG/9DgBNoK+DtbWjIBXP6vKnLLmlhD6Q0FBJ/SZHYt8RxhZ+Pl53yi64UXuzWxlRgkfHmQcBCpSGbuNVPJnNedJx3Th+S7sIgbmjAKsppUXDy2Q5wadP0gUI+6waM0Do3Ksz8eUl7+JI4MQJyszjVZFCbep5ldXzmKVzTy7Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=WsppvxBC; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="WsppvxBC" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 510801F00A3E; Fri, 10 Jul 2026 18:07:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1783706841; bh=CkkWKKS0uGZCaAHGZBZy/8v2NW2sWpG1nQLGD//HsUQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References; b=WsppvxBCzNiHA7uoHo0VR2TJVPWjt9pSO/0hSJCG1lkGLBe5DyuwNAe3fKC+XOwtT n9wKT+g36dNs2uaIzJdV5Cj32Wx6PQ0IiT0h10udXo8vg6HUbtL1w9slXsY/USPYnr RJPd7w3FiCbGwhznkeP8RMY7foGPkjqIEJ0ZjCeh2YWkPILgE6i6kKbMHpD5QQ2ltL OzjSQMuD4Ryxl3sPI3AVcBgZ/FAEOmE1HNbYWQbj1qS6RP6wUFZwQxPAg4rJLLqoXH E+m0L9qwLlSB4lbhXP6fi8dfo3IvXVLYJb66i2o0k5SNW9yeww4r+LITe1SlE6Gzd2 7NO5dqZSJQj0Q== From: Bjorn Andersson To: mathieu.poirier@linaro.org, Uday Khare Cc: linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: (subset) [PATCH 1/4] remoteproc: qcom: Fix glink->node reference leak in qcom_add_glink_subdev Date: Fri, 10 Jul 2026 13:07:06 -0500 Message-ID: <178370682991.2572738.9046057904322921905.b4-ty@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260618132054.11010-1-udaykhare77@gmail.com> References: <20260618132054.11010-1-udaykhare77@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit On Thu, 18 Jun 2026 18:50:54 +0530, Uday Khare wrote: > In qcom_add_glink_subdev(), the device node reference acquired via > of_get_child_by_name() is stored in glink->node. If the subsequent > kstrdup_const() allocation for glink->ssr_name fails, the function > returns early without calling of_node_put() on glink->node, leaking > the reference count. > > Fix this by adding of_node_put(glink->node) on the error path before > returning. > > [...] Applied, thanks! [1/4] remoteproc: qcom: Fix glink->node reference leak in qcom_add_glink_subdev commit: ed5dd2a9b716568ff7d6446322ee60846af313aa Best regards, -- Bjorn Andersson