From: "Martin K. Petersen" <martin.petersen@oracle.com>
To: Ram Vegesna <ram.vegesna@broadcom.com>,
"James E . J . Bottomley" <James.Bottomley@HansenPartnership.com>,
WenTao Liang <vulab@iscas.ac.cn>
Cc: "Martin K . Petersen" <martin.petersen@oracle.com>,
Vitaliy Shevtsov <v.shevtsov@mt-integration.ru>,
Daniel Wagner <dwagner@suse.de>, Kees Cook <kees@kernel.org>,
James Smart <jsmart2021@gmail.com>,
linux-scsi@vger.kernel.org, target-devel@vger.kernel.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] scsi: elx: efct: fix refcount leak in efct_hw_io_abort()
Date: Sun, 12 Jul 2026 22:32:38 -0400 [thread overview]
Message-ID: <178390967077.3399387.1650905221698217241.b4-ty@oracle.com> (raw)
In-Reply-To: <20260611053037.63756-1-vulab@iscas.ac.cn>
On Thu, 11 Jun 2026 13:30:37 +0800, WenTao Liang wrote:
> When efct_hw_reqtag_alloc() fails in efct_hw_io_abort(), the error
> path returns -ENOSPC without releasing the reference obtained via
> kref_get_unless_zero() earlier in the function. All other error
> paths correctly drop the reference. This causes a permanent
> reference leak on the io_to_abort object.
>
> Additionally, the abort_in_progress flag is left set to true on
> this path, which means future abort attempts for the same I/O will
> immediately return -EINPROGRESS even though the abort was never
> submitted, effectively blocking recovery.
>
> [...]
Applied to 7.2/scsi-fixes, thanks!
[1/1] scsi: elx: efct: fix refcount leak in efct_hw_io_abort()
https://git.kernel.org/mkp/scsi/c/2c007acf7b31
--
Martin K. Petersen
prev parent reply other threads:[~2026-07-13 2:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-11 5:30 WenTao Liang
2026-06-15 9:35 ` Daniel Wagner
2026-07-13 2:32 ` Martin K. Petersen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=178390967077.3399387.1650905221698217241.b4-ty@oracle.com \
--to=martin.petersen@oracle.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=dwagner@suse.de \
--cc=jsmart2021@gmail.com \
--cc=kees@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=ram.vegesna@broadcom.com \
--cc=stable@vger.kernel.org \
--cc=target-devel@vger.kernel.org \
--cc=v.shevtsov@mt-integration.ru \
--cc=vulab@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®