From: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
To: linux-gpio@vger.kernel.org, Rosen Penev <rosenp@gmail.com>
Cc: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>,
Michael Buesch <m@bues.ch>, Linus Walleij <linusw@kernel.org>,
Bartosz Golaszewski <brgl@kernel.org>,
Nathan Chancellor <nathan@kernel.org>,
Bill Wendling <morbo@google.com>,
Justin Stitt <justinstitt@google.com>,
linux-kernel@vger.kernel.org, llvm@lists.linux.dev,
Nick Desaulniers <nick.desaulniers+lkml@gmail.com>
Subject: Re: [PATCH] gpio: bt8xx: use devm_ioremap_resource()
Date: Fri, 17 Jul 2026 10:58:46 +0200 [thread overview]
Message-ID: <178427872031.9452.11556035251702200753.b4-ty@oss.qualcomm.com> (raw)
In-Reply-To: <20260713232810.1144712-1-rosenp@gmail.com>
On Mon, 13 Jul 2026 16:28:10 -0700, Rosen Penev wrote:
> Replace the open-coded devm_request_mem_region() plus devm_ioremap()
> sequence with a single devm_ioremap_resource() call on the BAR0 resource.
> This reserves the region and maps it in one step, and maps the full BAR
> length instead of a hardcoded 0x1000 (BAR0 on the bt848/878 is a 4KB
> register block, so the mapped size is unchanged).
>
> devm_ioremap_resource() returns an ERR_PTR on failure, so check with
> IS_ERR() and propagate PTR_ERR(). Drop the now-redundant error message,
> as devm_ioremap_resource() already logs on every failure path. Since it
> can return -EPROBE_DEFER, place it early.
>
> [...]
Applied, thanks!
[1/1] gpio: bt8xx: use devm_ioremap_resource()
https://git.kernel.org/brgl/c/bbd8254da11c189072349003006091e8327e8d36
Best regards,
--
Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>
prev parent reply other threads:[~2026-07-17 8:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-13 23:28 Rosen Penev
2026-07-17 8:58 ` Bartosz Golaszewski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=178427872031.9452.11556035251702200753.b4-ty@oss.qualcomm.com \
--to=bartosz.golaszewski@oss.qualcomm.com \
--cc=brgl@kernel.org \
--cc=justinstitt@google.com \
--cc=linusw@kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=m@bues.ch \
--cc=morbo@google.com \
--cc=nathan@kernel.org \
--cc=nick.desaulniers+lkml@gmail.com \
--cc=rosenp@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox