From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f179.google.com (mail-qt1-f179.google.com [209.85.160.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 29E09285072 for ; Fri, 17 Jul 2026 22:02:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.179 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784325762; cv=none; b=WCNIkJeOfof1+Lt/Y7cz4CBbeZnGQcNaHHRLyaLKHZLIJRl13TJDxYt5M08+5g4Sos8lvGGm29YImQICM27AqRDh/EertZwEgnd0R65AkcSqF53YOXIAmRu5gOS/xriArJ4uomSjWjiBC784hRIhL+M2fbk/H/8qEEm1+yODz1g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784325762; c=relaxed/simple; bh=LxcbZe7BgnncPWKoPk5gxZGS/pQMdASC0LgCixjRw3Q=; h=MIME-Version:Content-Type:Subject:From:To:Cc:In-Reply-To: References:Date:Message-Id; b=IpsQbx1a54ydXQerozumVd5rl0u+RmBACOG1Ic/5IEWY/TVGXeWODPHFnuQvBBc+SgiDyzNDe0G3bFBf+C3P6uNw2qyhGNVJK0CJl9XOZN/q2XlWr/8HJVurLmaVLL42yt9vHIdyAx+hoQK3hcNT74JGG6SI1xf/QHvPNJ/uZO8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=soleen.com; spf=pass smtp.mailfrom=soleen.com; dkim=pass (2048-bit key) header.d=soleen.com header.i=@soleen.com header.b=ROU/9jFB; arc=none smtp.client-ip=209.85.160.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=soleen.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=soleen.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=soleen.com header.i=@soleen.com header.b="ROU/9jFB" Received: by mail-qt1-f179.google.com with SMTP id d75a77b69052e-51c2cce930cso48421131cf.0 for ; Fri, 17 Jul 2026 15:02:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=soleen.com; s=google; t=1784325760; x=1784930560; darn=vger.kernel.org; h=message-id:date:references:in-reply-to:cc:to:from:subject :content-transfer-encoding:content-type:mime-version:from:to:cc :subject:date:message-id:reply-to:content-type; bh=HlCwb+1ZnQlT8KXH+VzgKgpVkzFEV+OYr4Ev43BkCgI=; b=ROU/9jFBhTKMed4ivYwVLd4Fj3zpN8w7Q0sedEggcUepLZwu73KbZETPQhoGQOjaKP +Ez7sh0ys+CRONjZ9La7yrZrkrT9xHjxVQqRZQXtKn/YMUY8KnTJc6YRO1IUsLdr/PzQ dIHSGfBY0dKhmZfoIGIxKc90boJLgSuSbndwVmB0sKMVE13fq6U2dzL2Kg5YMZ3CoC/C LaDuDxoHLWA0hcUySyFTY3f/zEjg9PnxndM1vm2VEXDHZNARWbQHkW+N+bdt/nRyjd+T TfeD0SQc/TU1WIUVISGAFmie8pacIBkEE09hlKRbl1gMrkw9r7ynNZ+S5K15TFouB/zv zSRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784325760; x=1784930560; h=message-id:date:references:in-reply-to:cc:to:from:subject :content-transfer-encoding:content-type:mime-version:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=HlCwb+1ZnQlT8KXH+VzgKgpVkzFEV+OYr4Ev43BkCgI=; b=YA619KMtUh93N2cGzyeUCVVhfxqutRQeMyk/36K3MyYkP3PnVb9QGOOrrlsh0PNhEI JvJ4RfekV9tIQRA8CuE+0ikQjZtFZ2DBKxU3K6WDjIpsmrTY2YBK8SB3nxIkqYWJBntZ EYA0JI5sDAxv5wwSCePw0rc4qj/2apU5hABvIJf3EhyPMqsyytn1jDkrURRFzoWfZdmn mmhFvX1aurB12m7KqKFREzkbXWL5cGByfldnBBW81jGWPizTmSvEC0WAyjnP7WL8tZXt BhNdGWhlwzLf6L54CmuoK0/gCvABRp6yZnV1zTwo3abObV+pXe2doVasf0IB9zCS+D3P OqGQ== X-Forwarded-Encrypted: i=1; AHgh+RqgJtOzdR3yIoOmhah4Kxqo9QAXfLqRm4MpTu0xLi0lI6nYx+TFbOvkym+97k2zeKFKjOwrP0g5HVkUQzE=@vger.kernel.org X-Gm-Message-State: AOJu0Yy5dHD6q3SuvzHbHMWJv3IhpUjF0UXG+Kx0hehb9w3ketS8XsbQ XJ2/D9g3FpZA2iKVu/50gqJMcPl8jvXsZskvtqybnRhyWCKptXojBXHOkwRd1s9MJ8g= X-Gm-Gg: AfdE7cmawxvOAvLQRfVRJ7I577/f7B+v9LObOJ8QV2OK6vJMM1FyfbMabSkhHyLBYhJ +9Ll7es7S2H55GUrZ7tVaRxxVXBCR4/HrTz1hef5e8zcYIeMuo+OxLBd1DS50Krkuna1H4kbe3y eGl0xju5P5xrcYp4rfstfiPSCXtBrIqZJfkIR1M9wTlMApU18/NRM1Jpt1i7JZSHwBU2E4qGL6h K4yTBKLhzJbDzqUsRMmz33Z3Y2RP8OLkGAsj59dWEWXGN8xzDBOzbpE3dMq7aAWnEYsQ4RcHo1n nlkAhuKihVVO7zUIpy2HdzSQoZXtbKAc5R2XWf+xg8q5/y8GluTsLQn+nBfTUWx03DAanBovyrr grJwhG5WC+6ub81ubw/chSwW6xeqsS5xzLIcl9Ke/f4rqECtq/6QjUnviQEH56I4tMiHOGuJ9Tu u4L8moT5tMQZW2xELYK/WHf7ghOqRGoIcpU2exGV0= X-Received: by 2002:ac8:5f06:0:b0:519:51af:febd with SMTP id d75a77b69052e-5213f668ee9mr42987041cf.46.1784325759954; Fri, 17 Jul 2026 15:02:39 -0700 (PDT) Received: from [127.0.1.1] ([71.181.43.54]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-5214f016aa5sm21849151cf.17.2026.07.17.15.02.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jul 2026 15:02:39 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Subject: Re: [PATCH v7 07/12] PCI: Refactor matching logic for pci_dev_acs_ops From: Pasha Tatashin To: David Matlack Cc: kexec@lists.infradead.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-pci@vger.kernel.org, Adithya Jayachandran , Alexander Graf , Alex Williamson , Bjorn Helgaas , Chris Li , David Rientjes , Jacob Pan , Jason Gunthorpe , Jonathan Corbet , Josh Hilke , Leon Romanovsky , Lukas Wunner , Mike Rapoport , Parav Pandit , Pasha Tatashin , Pranjal Shrivastava , Pratyush Yadav , Saeed Mahameed , Samiullah Khawaja , Shuah Khan , Vipin Sharma , William Tu , Yi Liu In-Reply-To: <20260710212616.1351130-8-dmatlack@google.com> References: <20260710212616.1351130-1-dmatlack@google.com> <20260710212616.1351130-8-dmatlack@google.com> Date: Fri, 17 Jul 2026 22:02:35 +0000 Message-Id: <178432575544.189683.9290455764634301119.b4-review@b4> X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=586; i=pasha.tatashin@soleen.com; h=from:subject:message-id; bh=LxcbZe7BgnncPWKoPk5gxZGS/pQMdASC0LgCixjRw3Q=; b=owEBbQKS/ZANAwAKAbt3KEzbc3reAcsmYgBqWqZ+Wxzq3jD2mMABNI1669A+3RszfBn3ErJXV Y50TeZzWEGJAjMEAAEKAB0WIQRBMaqT7LRvGvB/NmK7dyhM23N63gUCalqmfgAKCRC7dyhM23N6 3sVSEACDLPUH2+MHEoWyXAsDxYRkVARIRC+B2caZvvSgXaiLKmKi7pEnnql+8FPdsbwKkqRf9Jo dQ2qaVmpxf3l7ARpfkVXvpF8obibHQVOtxBKAkqoFNEHzWZzOBT2vYoywdcdcaiRGpZ8X12q8Tl TZ6s50Ini0rYTCvZ6zZ0zyslIqeoYN/w21C1mnmLJA5l/oSdh8oF+nocO9jyy1UkYfclKEmsVfS aASn9AyStUUOLNMQvuee3N/W+Er5iAx44Oxg/HGGBmN+ofL/MrxdUAodAIg6NbpN0q5+5fKvDvD 3KJcKOTnhHwhzxV3DvLnf1mAjYQ/jx4J4sTJYd8zPRCFQzvZ6IDSdiVzymUbhQvcVC66zvWuSgM zuzoedeSeAq72CoyoWiZ8xLA3hfJyhDVh4pzPcDA46ZJ0AgW7nAoqHiYNPJVCbtB2qPsQSNgU4G 1APtHXn0r5wICS6gPX7ZNcb7gNjnMcy6DZnrtpb/EgW7mEZr3zXxyuTeJrA6i3CogY5HCwl3avb k6g3LAvAnL5AhxIdAkfMb/JyCoo7fbWVvu3QdRJZoo4BTMU36Y41oNHHfuKo4IvKo+GpHaqe6jl t0fLRciM4UeB0Huvqd6ER6xDzWL/FjnnKjzHSJX4hp19xMTADl+jaeSlOdLUWzkPxqF+6X+8KBF zC29UAmi2lxznvA== X-Developer-Key: i=pasha.tatashin@soleen.com; a=openpgp; fpr=CAAAB722DD22A081F0D49F35633A6A993D43B569 On Fri, 10 Jul 2026 21:26:10 +0000, David Matlack wrote: > Refactor the logic to match devices to pci_dev_acs_ops by factoring out > the loop and device matching into its own routine. This eliminates some > duplicate code between pci_dev_specific_enable_acs() and > pci_dev_specific_disable_acs_redir(), and will also be used in a > subsequent commit to check if a device requires device-specific > enable_acs() during a Live Update. > > [...] Reviewed-by: Pasha Tatashin -- Pasha Tatashin