From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qv1-f54.google.com (mail-qv1-f54.google.com [209.85.219.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 66CB83CBE8B for ; Fri, 17 Jul 2026 23:29:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.54 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784330992; cv=none; b=pSQ4wnMewFuZew2KhUtL0ANjjuLX5vgjuiNo292Aad3Ti/52JeUXfNwpk3SIhhKkiYNMYzu0mgWeku1XWdzLXlkaty3H9nsqGyTtDU20ET+HyKEsvz/6/gpqHz+Oer4waC1WRSHRWQ8xEQal/e29JorVi9ds51obkOJf3IuUEac= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784330992; c=relaxed/simple; bh=6J2VFoOheObNIbZ6/cGmHoej1PdGKGdAP4cvYQKgG9k=; h=MIME-Version:Content-Type:Subject:From:To:Cc:In-Reply-To: References:Date:Message-Id; b=i+mvjY8Q2qhFuEOuplJc+wyPIYu904w5+1JIIRfjtASKgxILcelVYp11f4vTkxjBS/m7OljYYlMQsy47pzwbCiLKyAYfJOcwxQBwP54OP3cNdZboQDrq3BRP4zg45Wv0tbho/6OE0Jzrjt7LBjh+Vcco3XzBc/bY6Mh8ou55BcU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=soleen.com; spf=pass smtp.mailfrom=soleen.com; dkim=pass (2048-bit key) header.d=soleen.com header.i=@soleen.com header.b=OSLXgBtA; arc=none smtp.client-ip=209.85.219.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=soleen.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=soleen.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=soleen.com header.i=@soleen.com header.b="OSLXgBtA" Received: by mail-qv1-f54.google.com with SMTP id 6a1803df08f44-8f29ec73064so78743406d6.1 for ; Fri, 17 Jul 2026 16:29:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=soleen.com; s=google; t=1784330990; x=1784935790; darn=vger.kernel.org; h=message-id:date:references:in-reply-to:cc:to:from:subject :content-transfer-encoding:content-type:mime-version:from:to:cc :subject:date:message-id:reply-to:content-type; bh=1uFYFSRoCsiTT7zcdwujRzQUpLdsx92sk9iYHDH24xs=; b=OSLXgBtAPc1fBN6D+TAlI3V2si/8u89m4Ss6h6TzBVQwndwZG1WrSuuVIj2IbeyT7R T1YhXpxktUi+my932RxnpVn3QnpNzKFjfe+6ibMP155x1AGIsd4iKIrb7uL8nA1GAOFR b2ipVS7ve8eHWKayQrbqDvYPrFnE/QOKPqeH1QZ5JHfOwe/WFbHeAqEnM139GCPGfHFr e4ttlD9ttTr5x0oA7SBeCSe5j9bU5o8d7nOmtnlXuRcH0W2JcRAky/uCs76tsy1Kg6bA FZ+IFDx9rYnbsHWpu7uHIqAdvBtp1BEpeDYlx4FE8By1a7HK0B6MoP1cmlPjJ57WECY5 R7Ww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1784330990; x=1784935790; h=message-id:date:references:in-reply-to:cc:to:from:subject :content-transfer-encoding:content-type:mime-version:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=1uFYFSRoCsiTT7zcdwujRzQUpLdsx92sk9iYHDH24xs=; b=bxDmTYH2qkcZXq/66QeuI0hDkQFMkyK0gHGoDE3zqfocv6tu7mHJerSAa/NW9BLNPP beTimZKM0sv8T0ASdVOfYBkgRgwaDOFqsajwIR/KXC0qGs+fhlDTD7jZ4XLKmX2Im1qo +aeJs+9xuXLejXCmNNvzt8RrTRknb0/E2nfGkVgunxrBnnsp/cuDvj3u3lutUdnqte+k rla/goySmB1T1HQtZGSLALhEUAIc5pgEyL+kc++iVieOL7EzZX0gHbFszH+YLMdov6A7 bJiS77jdzI6QOYl17NRzh9JLzxCdlCSGfDlAQpdHZtiUfxV/Nd8mZeKomlI/XLrJPmTZ aRUQ== X-Forwarded-Encrypted: i=1; AHgh+RpkX/bBueUGGcRsqc9OL2AJNyZrDtCo4JeHZg0dqKUx3F8bcQRXhLPrm+0Ky8XQ2jQiJHmL+xA0K1HGKOo=@vger.kernel.org X-Gm-Message-State: AOJu0Yz9hFoAkCbUPO7NFG/zbAZcZoBPlGlpbozt2wI9YRLPGuaxinHM jAUAjZqWkvBx1RvQZUkGw4DXGLewtduC8ryFCLgzOqo0uHdar8vRUK0PZGc4ZfxWQOY= X-Gm-Gg: AfdE7cn+QOIXRximL6ep8s90zNmgFd3PXqJJSdeEqW+XnjHbnkVdmcyqqY6LUe/3Gsa oVoXOV63jBvJCgnvQiYzV2xKCJXm3IoCrY5MzgHkmlkTi7HWWP4xgA77w9m10rbIfTrPG/oImZj V7UVgqwyKqhuj84EA1TqzHl2F+joqk+q2z5ZAaZSYJLpSgB7VsL0pHJjDNi1gvkexkdBJeRtyaM YM+GJQItNtVdMCo9L1ThEqUw1H5W15KEF15a9rnJiK/no6mMbaHJyifcVah4e5PPMbXyNY27ETx MaP7L5/iaoJURoTP35fCISVMkEDUU4xVM0qq5FkpWUzHZKWRPex9SKji8+JV47Vt+1y2o1gTIcJ UQR84QDTtansNEwhBsf45YsxS+PqHfw/s6Y5aJ22bW1NVr9ogk7gZhtQyR/1Y02ItuvWjpLxi/2 qEZnrBxbIL6nCu1/+791Fkn2Vp+vQEZ4j5vKvgZf4E+zg+cjixvg== X-Received: by 2002:a05:6214:5c49:b0:8fb:81c5:7997 with SMTP id 6a1803df08f44-9077850e2c1mr54008216d6.31.1784330990189; Fri, 17 Jul 2026 16:29:50 -0700 (PDT) Received: from [127.0.1.1] ([71.181.43.54]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-907787298b9sm28260406d6.48.2026.07.17.16.29.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 17 Jul 2026 16:29:49 -0700 (PDT) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Subject: Re: [PATCH v7 09/12] PCI: liveupdate: Inherit ARI Forwarding Enable on preserved bridges From: Pasha Tatashin To: David Matlack Cc: kexec@lists.infradead.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-pci@vger.kernel.org, Adithya Jayachandran , Alexander Graf , Alex Williamson , Bjorn Helgaas , Chris Li , David Rientjes , Jacob Pan , Jason Gunthorpe , Jonathan Corbet , Josh Hilke , Leon Romanovsky , Lukas Wunner , Mike Rapoport , Parav Pandit , Pasha Tatashin , Pranjal Shrivastava , Pratyush Yadav , Saeed Mahameed , Samiullah Khawaja , Shuah Khan , Vipin Sharma , William Tu , Yi Liu In-Reply-To: <20260710212616.1351130-10-dmatlack@google.com> References: <20260710212616.1351130-1-dmatlack@google.com> <20260710212616.1351130-10-dmatlack@google.com> Date: Fri, 17 Jul 2026 23:29:45 +0000 Message-Id: <178433098576.189683.2364970585754668266.b4-review@b4> X-Mailer: b4 0.15.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=888; i=pasha.tatashin@soleen.com; h=from:subject:message-id; bh=6J2VFoOheObNIbZ6/cGmHoej1PdGKGdAP4cvYQKgG9k=; b=owEBbQKS/ZANAwAKAbt3KEzbc3reAcsmYgBqWrrshWLAQfvPS4hCFjntJqjX0KdHUleGb+svS eNoqDsCDGKJAjMEAAEKAB0WIQRBMaqT7LRvGvB/NmK7dyhM23N63gUCalq67AAKCRC7dyhM23N6 3n6BD/93+EXV7xpXf2NVyjjavXthNzeAZsOjnEaI/9CTjGZpZezuLCaFWFkZbkDaJEae3J38p4g juh65pYyMlwdowYBLYitqy4Ier6vbyyxoTsXaj3h/5m7FYus2rP1L70rvxqIWUKVDa7ae4mcHP8 jx4t1Y7WnDY7cDIIBbDBOVWz/TUe4B/nhCyh923/V+f3mvMwSMrkjpeg0snqGfcXX1/MgSHzSXx JxlP4a0WAMxKCYZJErzZ2J4BDcRpMPVf0Wogx/PmJlJ44HAR0obpH/l7e/l8mlIfJyTBnC0BOcd CRxdwB4gQwt8tYXq6ojekcZQGo5tkLGjVU/FRP9nzKbGUoIwwajPcQw2k9Wy0QrUHOHr0YepxNa PDOxIex+hWFFkDdyz0K+A6aSa1S8Wbkc78gHQcx++rNOheuVA4I1tNb2mW0+CmOfdK2W+Xq7qzU 8H4RB21Ijq3rJnHjvcfH9Y7rNyN0XbXdraIJKmVcg3iQiykYkN033FyDlHK3Xxs7+VkXpfehQU7 HVwPoEC6LyiXUZuPvqNPlP9IBcUFEKJtHRGZQvO84eyZvv0IyG2a4olE3gptNO3xeHXM5rLoij7 +UQOk3YJ0MWvmomRHmA6P0cgqW7ejMNyEJU2GfTch92NagNbGdNLnxWPd3YVdcov/hPE9GI6NTE y4FR9mOBy865agA== X-Developer-Key: i=pasha.tatashin@soleen.com; a=openpgp; fpr=CAAAB722DD22A081F0D49F35633A6A993D43B569 On Fri, 10 Jul 2026 21:26:12 +0000, David Matlack wrote: > diff --git a/drivers/pci/liveupdate.c b/drivers/pci/liveupdate.c > index a95bfe5eff77..74a11e520f0d 100644 > --- a/drivers/pci/liveupdate.c > +++ b/drivers/pci/liveupdate.c > @@ -816,6 +820,20 @@ int pci_liveupdate_enable_acs(struct pci_dev *dev) > return 0; > } > > +int pci_liveupdate_configure_ari(struct pci_dev *dev) > +{ > + u16 val; > + > + guard(rwsem_read)(&pci_liveupdate.rwsem); > + > + if (!dev->liveupdate.incoming) > + return -EINVAL; > + > + pcie_capability_read_word(dev, PCI_EXP_DEVCTL2, &val); > + dev->ari_enabled = !!(val & PCI_EXP_DEVCTL2_ARI); unsigned int ari_enabled:1; Sashiko asks a valid question, what protects other bits in this word during modication? At a very list a comment is needed. -- Pasha Tatashin