From: Sebastian Reichel <sebastian.reichel@collabora.com>
To: Sebastian Reichel <sre@kernel.org>, Anas Khan <anxkhn28@gmail.com>
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] power: supply: bq256xx: drop always-true inner condition
Date: Tue, 21 Jul 2026 01:12:58 +0200 [thread overview]
Message-ID: <178458917800.375902.7827717389755566253.b4-ty@collabora.com> (raw)
In-Reply-To: <20260702194547.65209-1-anxkhn28@gmail.com>
On Fri, 03 Jul 2026 01:15:47 +0530, Anas Khan wrote:
> In bq256xx_array_parse() the inner "if (val < array[i])" repeats the
> second half of the enclosing "if (val > array[i - 1] && val < array[i])",
> so it is always true and the "else return i" arm is dead code. The
> function performs a round-down table lookup, so returning i - 1 for a
> value that falls strictly between two entries is the intended result.
> Collapse the redundant branch into a single "return i - 1;"; no
> functional change.
>
> [...]
Applied, thanks!
[1/1] power: supply: bq256xx: drop always-true inner condition
commit: c41f57bb3b65fe0b2f5f556752dc03ac66b8c5db
Best regards,
--
Sebastian Reichel <sebastian.reichel@collabora.com>
prev parent reply other threads:[~2026-07-20 23:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-02 19:45 Anas Khan
2026-07-20 23:12 ` Sebastian Reichel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=178458917800.375902.7827717389755566253.b4-ty@collabora.com \
--to=sebastian.reichel@collabora.com \
--cc=anxkhn28@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®