From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7F246339387; Wed, 22 Jul 2026 10:30:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.167.242.64 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784716236; cv=none; b=Q96QsgCjjtM70l38peiz+zoMtBBRdpJXeyCPa9DrE47PDP3Ve32UJcQqsn7WFyj0DQxcyYsOxRYRWyAyv5A+dKyyJHHoP8tYaGc8AlihcqDpG5I6jr4dqJAHOiHhQnntSwIQxj8e2L+pFewp9MOweFqdkM54d2xsUBp56hkkvBI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1784716236; c=relaxed/simple; bh=WLv1NkIuFdslnB3lO6t5E/jNo8c9nJpw4Hrm3G2sqfc=; h=Content-Type:MIME-Version:In-Reply-To:References:Subject:From:Cc: To:Date:Message-ID; b=GQXCydDJENILrGp4VsVIqX97nY2ODjaL20SE9H4VqTX67Ck2oJ1OfJzquoj95/MEr8u6ZJ6ooPwLJmjjtE49CuuV+7dFYdLQGQ2SEc9geT6cY77F+NuXRgtJqRtZdpkA7kUF5oCb3dB6Y7Qm5G9gzSzlnOlI3qt6NnJtcQchYOw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com; spf=pass smtp.mailfrom=ideasonboard.com; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b=m3/Qrnom; arc=none smtp.client-ip=213.167.242.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ideasonboard.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="m3/Qrnom" Received: from monstersaurus.ideasonboard.com (cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 3C0A2447; Wed, 22 Jul 2026 12:29:31 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1784716171; bh=WLv1NkIuFdslnB3lO6t5E/jNo8c9nJpw4Hrm3G2sqfc=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=m3/QrnomGMN98IKkxI3JhTOOEPJeWtjSrGgXu8oSmMMVQpE83+JZfaezN+0OuStRO UC0Zk07S3nQbm5k+9lbybLfuHAqHlmtNh2de0HMZ3GrdLO798KY3dA53WBv4ufUJr+ jSynp7Y952/5N1dSAKZtkxWZYLNWDz5xq1MdYnN8= Content-Type: text/plain; charset="utf-8" Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: <3ak4ffamwvdrtgw3bivzvrbtkmyh7g3lvuk4xwvdiuzizi3iu3@uxqvyif7rvpx> References: <20260713-v1-verdin-imx8mm-dtbos-v1-0-4acd63db4504@toradex.com> <20260713-v1-verdin-imx8mm-dtbos-v1-6-4acd63db4504@toradex.com> <3ak4ffamwvdrtgw3bivzvrbtkmyh7g3lvuk4xwvdiuzizi3iu3@uxqvyif7rvpx> Subject: Re: [PATCH 6/8] arm64: dts: freescale: imx8mm-verdin: Add Toradex OV5640 CSI Cameras From: Kieran Bingham Cc: Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Francesco Dolcini , imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Ernest Van Hoecke To: Ernest Van Hoecke , Frank Li Date: Wed, 22 Jul 2026 11:30:29 +0100 Message-ID: <178471622928.2174993.5439033710284861967@ping.linuxembedded.co.uk> User-Agent: alot/0.9.1 Quoting Ernest Van Hoecke (2026-07-22 10:27:32) > On Mon, Jul 20, 2026 at 02:16:46PM -0400, Frank Li wrote: > > On Mon, Jul 13, 2026 at 05:06:27PM +0200, Ernest Van Hoecke wrote: > > > From: Ernest Van Hoecke > > > > > > Add device tree overlays for the Toradex OV5640 CSI Camera on Verdin = CSI_1. > > > > > > The default overlay describes the current CSI Camera Set 5MP OV5640 w= ith a > > > 27 MHz on-board oscillator. Add a separate 24 MHz overlay for the leg= acy > > > camera module. > > > > > > Link: https://developer.toradex.com/hardware/accessories/cameras/csi-= camera-module-5mp-ov5640-arducam > > > Link: https://www.toradex.com/accessories/csi-camera-ov5640 > > > Link: https://developer.toradex.com/hardware/legacy-products/other/cs= i-camera-module-5mp-ov5640/ > > > Signed-off-by: Ernest Van Hoecke > > > --- > > > arch/arm64/boot/dts/freescale/Makefile | 6 ++ > > > .../dts/freescale/imx8mm-verdin-ov5640-24mhz.dtso | 17 +++++ > > > .../boot/dts/freescale/imx8mm-verdin-ov5640.dtsi | 78 ++++++++++++= ++++++++++ > > > .../boot/dts/freescale/imx8mm-verdin-ov5640.dtso | 18 +++++ > > > 4 files changed, 119 insertions(+) > > > > > > diff --git a/arch/arm64/boot/dts/freescale/Makefile b/arch/arm64/boot= /dts/freescale/Makefile > > > index c465aa19e526..ed3d678e7c5e 100644 > > > --- a/arch/arm64/boot/dts/freescale/Makefile > > > +++ b/arch/arm64/boot/dts/freescale/Makefile > > > @@ -189,6 +189,8 @@ dtb-$(CONFIG_ARCH_MXC) +=3D imx8mm-verdin-nonwifi= -mallow.dtb > > > dtb-$(CONFIG_ARCH_MXC) +=3D imx8mm-verdin-nonwifi-yavia-dsi-to-hdmi.= dtb > > > dtb-$(CONFIG_ARCH_MXC) +=3D imx8mm-verdin-nonwifi-yavia.dtb > > > dtb-$(CONFIG_ARCH_MXC) +=3D imx8mm-verdin-nonwifi-zinnia.dtb > > > +dtb-$(CONFIG_ARCH_MXC) +=3D imx8mm-verdin-ov5640-24mhz.dtbo > > > +dtb-$(CONFIG_ARCH_MXC) +=3D imx8mm-verdin-ov5640.dtbo > >=20 > > Need not add dtbo here, > >=20 > > +dtb-$(CONFIG_ARCH_MXC) +=3D imx8mm-verdin-wifi-dev-ov5640-24mhz.dtb can > > auto dtbo build dtbo. > >=20 > > check other dtbo. > >=20 > > Frank > >=20 >=20 > Hi Frank, >=20 > Thanks for the review. >=20 > Our desire is that these dtbo's are standalone targets that are shipped > for runtime overlay application. Users might, on dev boards especially, > want to enable or disable any combination of these overlays, and change > the combination between boots. >=20 > The combined dtb targets validate the overlay and in some listed cases, > provide a ready-to-use combo. They are not intended to cover all > possible use-cases. >=20 > My understanding is that indeed a dtb-y targeting a combined DTB will > build the prerequisite dtbo, but it would not be an install target. I think with the Toradex ecosystem there would be some value in supporting or helping with the ongoing dt-connectors or dt-addons topics so that we can abstract the hardware which is being 'added'. I think it's important that we tackle the problem of combinatorial explosions of overlays when we can add a component to multiple platforms. For example, your OV5640 camera could be added to many different boards - and each board could have many different cameras - in different ports. We should not be copy/pasting overlays for each combination, or we'll have 'thousands' of identical overlays. -- Kieran >=20 > Kind regards, > Ernest >