From: Will Deacon <will@kernel.org>
To: Joerg Roedel <joro@8bytes.org>,
Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>,
Robin Murphy <robin.murphy@arm.com>,
iommu@lists.linux.dev, linux-kernel@vger.kernel.org,
lirongqing <lirongqing@baidu.com>
Cc: catalin.marinas@arm.com, kernel-team@android.com,
Will Deacon <will@kernel.org>
Subject: Re: [PATCH] iommu/amd: Fix undefined behavior in devid_write debugfs function
Date: Wed, 22 Jul 2026 22:39:26 +0100 [thread overview]
Message-ID: <178472357092.2860701.3018630153871589753.b4-ty@kernel.org> (raw)
In-Reply-To: <20260601121240.2474-1-lirongqing@baidu.com>
On Mon, 01 Jun 2026 08:12:40 -0400, lirongqing wrote:
> When for_each_pci_segment() loop completes without finding a matching
> segment, the pci_seg pointer is not NULL but points to an invalid memory
> location (the list head). Accessing pci_seg->id after the loop causes
> undefined behavior.
>
> Fix this by handling the successful case inside the loop and returning
> -EINVAL after the loop if no matching segment is found.
>
> [...]
Applied to iommu (amd/amd-vi), thanks!
[1/1] iommu/amd: Fix undefined behavior in devid_write debugfs function
https://git.kernel.org/iommu/c/843e14998966
Cheers,
--
Will
https://fixes.arm64.dev
https://next.arm64.dev
https://will.arm64.dev
prev parent reply other threads:[~2026-07-22 21:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-01 12:12 lirongqing
2026-06-02 4:48 ` Ankit Soni
2026-07-21 12:24 ` 答复: [????] " Li,Rongqing
2026-07-22 21:39 ` Will Deacon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=178472357092.2860701.3018630153871589753.b4-ty@kernel.org \
--to=will@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=iommu@lists.linux.dev \
--cc=joro@8bytes.org \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lirongqing@baidu.com \
--cc=robin.murphy@arm.com \
--cc=suravee.suthikulpanit@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®