From: Andrew Jeffery <andrew@codeconstruct.com.au>
To: Avi Fishman <avifishman70@gmail.com>,
Tomer Maimon <tmaimon77@gmail.com>,
Tali Perry <tali.perry1@gmail.com>,
Yuho Choi <dbgh9129@gmail.com>
Cc: Patrick Venture <venture@google.com>,
Nancy Yuen <yuenn@google.com>,
Benjamin Fair <benjaminfair@google.com>,
Russell King <linux@armlinux.org.uk>,
openbmc@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v1] ARM: npcm: Fix OF node refcount leaks in SMP setup
Date: Wed, 22 Jul 2026 23:23:38 +0930 [thread overview]
Message-ID: <178472841877.1739993.4789559545976492167.b4-ty@b4> (raw)
In-Reply-To: <20260525033846.1346744-1-dbgh9129@gmail.com>
On Sun, 24 May 2026 23:38:46 -0400, Yuho Choi wrote:
> npcm7xx_smp_boot_secondary() and npcm7xx_smp_prepare_cpus() look up
> the GCR and SCU nodes with of_find_compatible_node(). The returned
> nodes are used for of_iomap(), but the node references are never
> released.
>
> of_iomap() does not consume the device node reference, and iounmap()
> only releases the MMIO mapping. Drop each node reference after the
> corresponding mapping attempt.
>
> [...]
Thanks, I've applied this to the BMC tree.
--
Andrew Jeffery <andrew@codeconstruct.com.au>
prev parent reply other threads:[~2026-07-22 13:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-25 3:38 Yuho Choi
2026-06-26 2:21 ` 최유호
2026-07-22 13:53 ` Andrew Jeffery [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=178472841877.1739993.4789559545976492167.b4-ty@b4 \
--to=andrew@codeconstruct.com.au \
--cc=avifishman70@gmail.com \
--cc=benjaminfair@google.com \
--cc=dbgh9129@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=openbmc@lists.ozlabs.org \
--cc=tali.perry1@gmail.com \
--cc=tmaimon77@gmail.com \
--cc=venture@google.com \
--cc=yuenn@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®