From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6D54F347BD9
	for <linux-kernel@vger.kernel.org>; Thu, 23 Jul 2026 03:45:17 +0000 (UTC)
Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18
ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116;
	t=1784778318; cv=none; b=kWV/V+HDZLvTfHoa/9uGmLHNTj1DSWoq5JnJzEvr01cJffzMhGXOtcBny57kBIxgzqbyzOt6/miNxi5L22Sm4JUL6/5e8wkxj9a8ESVUx5rGxm82TMC5ElgiQAkF7ATJm9GuOKHt4rlt8SAzsyV/PF3ZBV2xUhKU8eU/Wp45Pxs=
ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org;
	s=arc-20240116; t=1784778318; c=relaxed/simple;
	bh=JgQjj7iHtPObMlZKoR7QEbSyV2RjH5PMuF5YUhZhuBE=;
	h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References:
	 MIME-Version:Content-Type; b=XLxcMaIProgfsGnKXZLJ67MaYDHV2snU/LkXZ+lS8+3UiBGVvQu1wS1qacLW+okwvdq9Ev6SWSKjqSh1p4/9Kc5mgYQ/u6rHmoJzxGOso0S+DIpbJo/x0WrYedDlpwyrpA6XyUc5aam1srBbsULMdelJKA4eaCcCptXn0SATkPk=
ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=kA4N1gHb; arc=none smtp.client-ip=100.103.45.18
Authentication-Results: smtp.subspace.kernel.org;
	dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="kA4N1gHb"
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 173DF1F000E9;
	Thu, 23 Jul 2026 03:45:17 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org;
	s=k20260515; t=1784778317;
	bh=762g8kYBk7lElwigO/Zsr8G9z8HnpHqNCurBk1LuKrE=;
	h=From:To:Cc:Subject:Date:In-Reply-To:References;
	b=kA4N1gHb3nJw/caFpk+zcO5zBuVRkiwLvH3IZoY/LzrxvYHLB2xd4AoCSsMJKFb1+
	 4pYFxIkozgxBzPHNcBgVh/R0WVsJA48HvhrC6lb10OrV6eNluL8eexI2VL3VaR5Q62
	 XPE38DSIRUbmxpzFH+Eu2hYcB1Xq3jIspibyUH81JZjh/lqNUncn/qWo+2Yv3CJvEz
	 gDxmCOAuNsOt/Bdh6KsLD+jeYMXWpXXs5NlRkIIwWW25vI4UM9fZfgG/8nNf1BI2Ze
	 bB7IcRBHAOSXfOZmPpwPgHRBoIOgQwhKLBbQeP5UPTaZxPjizvwhSvyFWiSKEc7rku
	 JiVIbxaNJNEjw==
From: Kees Cook <kees@kernel.org>
To: Thomas Gleixner <tglx@kernel.org>,
	Ingo Molnar <mingo@redhat.com>,
	Borislav Petkov <bp@alien8.de>,
	Dave Hansen <dave.hansen@linux.intel.com>,
	x86@kernel.org,
	"H. Peter Anvin" <hpa@zytor.com>,
	Andi Kleen <andi@firstfloor.org>,
	"Lorenzo Stoakes (ARM)" <ljs@kernel.org>
Cc: Kees Cook <kees@kernel.org>,
	linux-kernel@vger.kernel.org,
	linux-mm@kvack.org
Subject: Re: [PATCH] x86/elf: Correct comment for STACK_RND_MASK()
Date: Wed, 22 Jul 2026 20:45:04 -0700
Message-Id: <178477830120.3132185.17815722457437200154.b4-ty@kernel.org>
X-Mailer: git-send-email 2.34.1
In-Reply-To: <20260722-fix-x86-comment-v1-1-605080af988d@kernel.org>
References: <20260722-fix-x86-comment-v1-1-605080af988d@kernel.org>
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

On Wed, 22 Jul 2026 19:44:43 +0100, Lorenzo Stoakes (ARM) wrote:
> Commit 913bd9060195 ("[PATCH] x86_64: Increase the variability of the
> process stack on 64bit architectures"), merged in 2006, increased stack
> randomisation from 8 MiB to an ostensible 1 GiB for 64-bit systems.
> 
> However the commit actually introduced a mask of 0x3fffff * 4 KiB pages
> which provides 16 GiB of randomisation, not 1 GiB.
> 
> [...]

Applied to for-next/execve, thanks!

[1/1] x86/elf: Correct comment for STACK_RND_MASK()
      https://git.kernel.org/kees/c/ab11176bd3a7

Take care,

-- 
Kees Cook