From: "Theodore Ts'o" <tytso@mit.edu>
To: adilger.kernel@dilger.ca, libaokun@linux.alibaba.com,
jack@suse.cz, ojaswin@linux.ibm.com, ritesh.list@gmail.com,
yi.zhang@huawei.com, ebiggers@google.com,
Yun Zhou <yun.zhou@windriver.com>
Cc: "Theodore Ts'o" <tytso@mit.edu>,
linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] ext4: fix circular lock dependency in ext4_ext_migrate
Date: Thu, 23 Jul 2026 09:08:54 -0400 [thread overview]
Message-ID: <178481171723.796182.8994536002589226058.b4-ty@b4> (raw)
In-Reply-To: <20260612005330.1930804-1-yun.zhou@windriver.com>
On Fri, 12 Jun 2026 08:53:30 +0800, Yun Zhou wrote:
> Move iput(tmp_inode) after ext4_writepages_up_write() to avoid a
> circular lock dependency between s_writepages_rwsem and sb_internal
> (freeze protection).
>
> The deadlock scenario:
>
> CPU0 (EXT4_IOC_MIGRATE) CPU1 (orphan cleanup during mount)
> ---- ----
> ext4_ext_migrate()
> ext4_writepages_down_write()
> s_writepages_rwsem (write)
> ext4_evict_inode()
> sb_start_intwrite() [sb_internal]
> ...
> ext4_writepages()
> s_writepages_rwsem (read) [BLOCKED]
> iput(tmp_inode)
> ext4_evict_inode()
> sb_start_intwrite() [BLOCKED]
>
> [...]
Applied, thanks!
[1/1] ext4: fix circular lock dependency in ext4_ext_migrate
commit: a897682793eba5de51ee6f3152760374afa629cf
Best regards,
--
Theodore Ts'o <tytso@mit.edu>
prev parent reply other threads:[~2026-07-23 13:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-09 8:40 [PATCH] " Yun Zhou
2026-06-09 12:05 ` Jan Kara
2026-06-10 7:04 ` Zhou, Yun
2026-06-10 10:21 ` Jan Kara
2026-06-10 10:30 ` [PATCH v2] " Yun Zhou
2026-06-12 0:53 ` [PATCH v3] " Yun Zhou
2026-06-16 7:51 ` Zhou, Yun
2026-06-16 9:07 ` Jan Kara
2026-06-29 7:10 ` Zhou, Yun
2026-07-14 5:55 ` Zhou, Yun
2026-07-23 13:08 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=178481171723.796182.8994536002589226058.b4-ty@b4 \
--to=tytso@mit.edu \
--cc=adilger.kernel@dilger.ca \
--cc=ebiggers@google.com \
--cc=jack@suse.cz \
--cc=libaokun@linux.alibaba.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ojaswin@linux.ibm.com \
--cc=ritesh.list@gmail.com \
--cc=yi.zhang@huawei.com \
--cc=yun.zhou@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®