From: Ojaswin Mujoo <ojaswin@linux.ibm.com>
To: linux-ext4@vger.kernel.org, "Theodore Ts'o" <tytso@mit.edu>
Cc: Ritesh Harjani <riteshh@linux.ibm.com>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
Jan Kara <jack@suse.cz>, Kemeng Shi <shikemeng@huaweicloud.com>,
"Ritesh Harjani (IBM)" <ritesh.list@gmail.com>
Subject: [PATCH 03/13] ext4: Remove unused extern variables declaration
Date: Thu, 25 May 2023 17:02:57 +0530 [thread overview]
Message-ID: <1784dcc5422f1f37068704be565b8e16f4d51f19.1685009579.git.ojaswin@linux.ibm.com> (raw)
In-Reply-To: <cover.1685009579.git.ojaswin@linux.ibm.com>
From: "Ritesh Harjani (IBM)" <ritesh.list@gmail.com>
ext4_mb_stats & ext4_mb_max_to_scan are never used. We use
sbi->s_mb_stats and sbi->s_mb_max_to_scan instead.
Hence kill these extern declarations.
Signed-off-by: Ritesh Harjani (IBM) <ritesh.list@gmail.com>
Signed-off-by: Ojaswin Mujoo <ojaswin@linux.ibm.com>
Reviewed-by: Jan Kara <jack@suse.cz>
---
fs/ext4/ext4.h | 2 --
fs/ext4/mballoc.h | 2 +-
2 files changed, 1 insertion(+), 3 deletions(-)
diff --git a/fs/ext4/ext4.h b/fs/ext4/ext4.h
index 7e8f66ba17f4..80e01fbcd0a3 100644
--- a/fs/ext4/ext4.h
+++ b/fs/ext4/ext4.h
@@ -2815,8 +2815,6 @@ int ext4_fc_record_regions(struct super_block *sb, int ino,
/* mballoc.c */
extern const struct seq_operations ext4_mb_seq_groups_ops;
extern const struct seq_operations ext4_mb_seq_structs_summary_ops;
-extern long ext4_mb_stats;
-extern long ext4_mb_max_to_scan;
extern int ext4_seq_mb_stats_show(struct seq_file *seq, void *offset);
extern int ext4_mb_init(struct super_block *);
extern int ext4_mb_release(struct super_block *);
diff --git a/fs/ext4/mballoc.h b/fs/ext4/mballoc.h
index 6d85ee8674a6..24b666e558f1 100644
--- a/fs/ext4/mballoc.h
+++ b/fs/ext4/mballoc.h
@@ -49,7 +49,7 @@
#define MB_DEFAULT_MIN_TO_SCAN 10
/*
- * with 'ext4_mb_stats' allocator will collect stats that will be
+ * with 's_mb_stats' allocator will collect stats that will be
* shown at umount. The collecting costs though!
*/
#define MB_DEFAULT_STATS 0
--
2.31.1
next prev parent reply other threads:[~2023-05-25 11:36 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-25 11:32 [PATCH 00/13] multiblock allocator improvements Ojaswin Mujoo
2023-05-25 11:32 ` [PATCH 01/13] Revert "ext4: remove ac->ac_found > sbi->s_mb_min_to_scan dead check in ext4_mb_check_limits" Ojaswin Mujoo
2023-05-25 12:24 ` Kemeng Shi
2023-06-02 13:41 ` Linux regression tracking #adding (Thorsten Leemhuis)
2023-05-25 11:32 ` [PATCH 02/13] ext4: mballoc: Remove useless setting of ac_criteria Ojaswin Mujoo
2023-05-25 11:32 ` Ojaswin Mujoo [this message]
2023-05-25 11:32 ` [PATCH 04/13] ext4: Fix a small typo in ext4_mb_prefetch_fini() Ojaswin Mujoo
2023-05-25 11:32 ` [PATCH 05/13] ext4: Convert mballoc cr (criteria) to enum Ojaswin Mujoo
2023-05-25 11:33 ` [PATCH 06/13] ext4: Add per CR extent scanned counter Ojaswin Mujoo
2023-05-25 11:33 ` [PATCH 07/13] ext4: Add counter to track successful allocation of goal length Ojaswin Mujoo
2023-05-25 11:33 ` [PATCH 08/13] ext4: Avoid scanning smaller extents in BG during CR1 Ojaswin Mujoo
2023-05-25 11:33 ` [PATCH 09/13] ext4: Don't skip prefetching BLOCK_UNINIT groups Ojaswin Mujoo
2023-05-25 11:33 ` [PATCH 10/13] ext4: Ensure ext4_mb_prefetch_fini() is called for all prefetched BGs Ojaswin Mujoo
2023-05-25 11:33 ` [PATCH 11/13] ext4: Abstract out logic to search average fragment list Ojaswin Mujoo
2023-05-25 11:33 ` [PATCH 12/13] ext4: Add allocation criteria 1.5 (CR1_5) Ojaswin Mujoo
2023-05-25 11:33 ` [PATCH 13/13] ext4: Give symbolic names to mballoc criterias Ojaswin Mujoo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1784dcc5422f1f37068704be565b8e16f4d51f19.1685009579.git.ojaswin@linux.ibm.com \
--to=ojaswin@linux.ibm.com \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ritesh.list@gmail.com \
--cc=riteshh@linux.ibm.com \
--cc=shikemeng@huaweicloud.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®