From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1A5F440BCA0 for ; Mon, 27 Jul 2026 13:08:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785157697; cv=none; b=Oghx53wjJfHgxAp+HZQL9vWt5xy9Gl2YADnXe4RrOz6RGMV7msue3j7mEyUfCAtkcLRodR0Z751TwJbFBGlctMjLsaT2aOTC824cXIcUUrlY0Cqfhs1o4ORwC7dJUinPiiF/eIl0IiWif1uZcsIo2nOozwuwNycoqcoZ8ZEEQ18= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785157697; c=relaxed/simple; bh=HYLFS+OFcWFTtSFm1PiU4CCDIq1dnlVTeFE2rXyTcVs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=mlxLCv+6g8MrgZm0i59eIlq4m+D+aD0rGiD/spArU29hRohcfBxm0WRHc9fDmtAXiJH11qLOCFmqri8dMp699G7AJhoXG413j93inB97ugGOHFOe7IAh2ycjwFq8iNVMcKQEEIlfO5S5g1hAZNUsK3huadN63RarymfnEmMYQnA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ZW+gRPaN; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=eDfOj6Ik; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ZW+gRPaN"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="eDfOj6Ik" Received: from pps.filterd (m0279869.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66RALwPS3647470 for ; Mon, 27 Jul 2026 13:08:15 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= LZHWggkPMw97tiUjUmvN6ppmZKNPFHubbsI0aW0BRH0=; b=ZW+gRPaNKY/yucJS oJd/kSuFbPVjfpEj8uMQSMeAxIlBsxYYC8FJKKcmKeJ/AXu60CBCOoHcxbX45Rzj LwUXf+AjR5YS61fmWC4o4H0Cvd5GhNpZ4UE3wihFmNFAvZkN/j14yam9Eu27t2cY 6F+AbrB+iXOxNRAjlkurLNyz6PCGkSisttOwPznaxyCfc9uL2NB4pofg3xfyjKmj VR3QXFQ626o5cBR08gb5BpnXd27j4qhMcPJOB5cdVWpaTpAYTA+GrmYMBDlMDVdg EeLkZuaiVOXgDucY12jlfbiRp86QZMywuMNZNXunX/4fyOnzQd/IOShdHr1X+TxI lCWewg== Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fp4mrrty9-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 27 Jul 2026 13:08:14 +0000 (GMT) Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-51c1eb52e1fso49028851cf.0 for ; Mon, 27 Jul 2026 06:08:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1785157694; x=1785762494; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=LZHWggkPMw97tiUjUmvN6ppmZKNPFHubbsI0aW0BRH0=; b=eDfOj6Ikz6QVCi/UrQWTug9VJl0dLoj3MQi0fxbhQmX/3J1y44pOFQoK8NE37RSMAy 8q4vmIXxhHsJ9XnN/VPoaRJqTrR+vUx8sLoR1Tk7ZPI4L8cPXr7ssEXDysA1Quoi9G7B kxdvNkZd4vMxWDUckaHMFrOLGJgh9bghtQP+nZ4gKEjEO2k07HQczH4lcNAYDkXic6HA wIkvU0cQ0N/tlEbx3Bviy/0LOJvqyAMhvsAIQEbrBl13Hv+vVSkgu+8YJ5mrvBsHymDs fj//z2PL3R4Te01DVN51n/hEj2t9WgbSwoMaGpKZ4NRcY+t0QawD40qV5sr/EvkRDmn/ 1Otw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785157694; x=1785762494; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=LZHWggkPMw97tiUjUmvN6ppmZKNPFHubbsI0aW0BRH0=; b=bT+lZqRRTH0BWlGh3/Gjkja1eWARP+T/KyE252PKqMbUhRvYEdcw3UCYfID4bCDy5/ kJANuiERlsCWQI4wpwqW8qBIYaJBtAk0LOA4y73fz0KeNGfjq8ir2a7UgJhA/+ac3Tsu 4Jw1XsVndyAJpIWR8W1gsLq5gbwzNvbm50IGtEI6tAxg4Pixf6qe43Sgzq1FRpgXj9fP Bt5N5YJXqbz3W5W2E3wGq7i2ka+UXQ+XNm5+dRlHHK/nDg5lxA081rvRkGmDCg6WhRgC iPEi+VowDEAfmUEUbmTA4DNC3OuVTaD0woxj1WUu0CzcRaAPp/zomYATs0AofpfAX9Df dKsA== X-Forwarded-Encrypted: i=1; AHgh+Roc3KyQ+/g5lbtMJ7le5trGT68KmKUt/O6f3N/ey4h3m1PvWaURRUBTMnqTUJlWDVTYzI0xrbPbEHP2Ato=@vger.kernel.org X-Gm-Message-State: AOJu0Yzgf6BEBjggZzrrXbwTTsTNqcjP77goHzTCS+HVjqm6z0+uKzfv SVXZrnbCu1fLjbSxrW9Eq9cOGVE6Wlzg4bAjFtvvSWJXQJrn5KXmjEa9+I7FvpQjJfjFPHiW6NH 7CKVoD0KqW9kd6f2RMB3O6PP29Sav4rWvPH8G0OagFuDw4Gz0s7BiT2xZZjy5OQz9JcA= X-Gm-Gg: AR+sD11H27YW3cyd3nBSFAGcmjD3Pczx7DGDg2Oai8ehZO8VyHe8POCAClcoHyB1S/X +TBB05eJU/T3je3hBCXNLr1ebwtrDwx+8xa4T43YNYkNsI2b85pNaxWf+Umo4NU5Lq4sNgXH8vi 2TYgc+mYf1bruNee8KME7DidWaQ75B806n6o6pMs1fJGCn+et5LpPKjj1dyuosfrhCoSNU5PtnR z3p9AQwq2yt0+1wr+Izr+aaoG8dpOMV1RXnmPdp4YDn11X8zRuVMtrDbuGFpb7k3dO2g7Ch1xHG 4Q3g09ZIqOhtYkzdnW1up9ZO8zCdp0hTXHMRLrLTSqxIiC61oy2AzPtZ4tovgS+57wLCHaQ/4ng ApPwZOPyKITas3paBTU4hlvk1FgU= X-Received: by 2002:ac8:570d:0:b0:51b:f98f:ea5e with SMTP id d75a77b69052e-529a84bb82bmr84853591cf.22.1785157694394; Mon, 27 Jul 2026 06:08:14 -0700 (PDT) X-Received: by 2002:ac8:570d:0:b0:51b:f98f:ea5e with SMTP id d75a77b69052e-529a84bb82bmr84852721cf.22.1785157693717; Mon, 27 Jul 2026 06:08:13 -0700 (PDT) Received: from brgl-qcom.home ([2a01:cb1d:dc:7e00:1449:2d40:6dd2:20d]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4957bfe07e1sm233635795e9.3.2026.07.27.06.08.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 27 Jul 2026 06:08:12 -0700 (PDT) From: Bartosz Golaszewski To: Bartosz Golaszewski , Linus Walleij , Andy Shevchenko , Junjie Cao Cc: Bartosz Golaszewski , Sebastian Andrzej Siewior , Clark Williams , Steven Rostedt , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rt-devel@lists.linux.dev, stable@vger.kernel.org Subject: Re: [PATCH] gpio: pch: use raw_spinlock_t for the register lock Date: Mon, 27 Jul 2026 15:08:11 +0200 Message-ID: <178515768299.55050.11621180913720960066.b4-ty@oss.qualcomm.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: <20260723014129.1129730-1-junjie.cao@intel.com> References: <20260723014129.1129730-1-junjie.cao@intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Info: AW1haW4tMjYwNzI3MDEyNyBTYWx0ZWRfX+TUZ0Z2J2k5s xCMzNhI9UEkaTngJ5fNCd2Fc3x1B6/TaYw2XevY+E38/gNNBYsKUk1/cKYu1V/JbEDcYekomuLj UvZdeajwauCuhiO/GLGveQ9dt4/lR10= X-Authority-Analysis: v=2.4 cv=UYBhjqSN c=1 sm=1 tr=0 ts=6a67583e cx=c_pps a=mPf7EqFMSY9/WdsSgAYMbA==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=_glEPmIy2e8OvE2BGh3C:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=K0IHqChC3_vQdOeRQfIA:9 a=QEXdDO2ut3YA:10 a=dawVfQjAaf238kedN5IG:22 X-Proofpoint-GUID: EMAbXunzWD1LalyU-5G_h83Guq-qUF0x X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzI3MDEyNyBTYWx0ZWRfXzUlBRXoQ84ZJ RJLmLzWKQfNsLV0ThHwzhPDBVRtIYzWoueaf4Gx9K7UOXr46e1+m4ca7/gHd0UOJ+VhcwGRD3Rp 7aBSH2khF2umkhOabcNPqXaNznm9Q75KGzjB8sN/JaW1FIaQ2Szx5Y6XZAxqD3oHMoUsrQeCW+1 WnWh4dAcMnlZ3dd42IGtpKKuyb2vtDL6dZZKeo7Ue1V8OyhFMEK6cTrnN5pbGdUlQ9OtgMqN6y3 EfAS5Syt0HBRExK5TvzASvDLk3we/Jwrn5DhHlZ07tjtp4e01rTksycBPx6qmO6EYtze75vwjU3 RvpkGfY/2y0xvmWgfgL9Uc+0EjADG+3ngHiaeQz1YD7Xf9T2xIQxQEw650Ls/chvqgcz6FPF2QN CNgyhaotb/hpk69WK5ZjsUUUqon0oL/ZIIItRYOxpNOb0GfOF2bAjybG+5HWfIecaoThRDHhzFP E8tVz2KGRtse9BD2pqw== X-Proofpoint-ORIG-GUID: EMAbXunzWD1LalyU-5G_h83Guq-qUF0x X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-27_03,2026-07-24_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 lowpriorityscore=0 suspectscore=0 bulkscore=0 clxscore=1015 priorityscore=1501 phishscore=0 adultscore=0 impostorscore=0 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607270127 On Thu, 23 Jul 2026 09:41:29 +0800, Junjie Cao wrote: > pch_irq_type() is registered as the irq_chip .irq_set_type callback and > takes chip->spinlock with spin_lock_irqsave(). This callback is reached > from __setup_irq() -> __irq_set_trigger() -> chip->irq_set_type() while > the caller holds desc->lock, a raw_spinlock_t, with hardirqs disabled. > That context is not sleepable, but on PREEMPT_RT a regular spinlock_t is > an rtmutex-backed sleeping lock, so acquiring it there is invalid. > > [...] Applied, thanks! [1/1] gpio: pch: use raw_spinlock_t for the register lock https://git.kernel.org/brgl/c/a02b8950d619123da64f69b70fe1dadef217dfe4 Best regards, -- Bartosz Golaszewski