From: Will Deacon <will@kernel.org>
To: Nicolin Chen <nicolinc@nvidia.com>
Cc: catalin.marinas@arm.com, kernel-team@android.com,
Will Deacon <will@kernel.org>,
Robin Murphy <robin.murphy@arm.com>,
"Joerg Roedel (AMD)" <joro@8bytes.org>,
linux-tegra@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, iommu@lists.linux.dev,
linux-kernel@vger.kernel.org, Jason Gunthorpe <jgg@ziepe.ca>
Subject: Re: [PATCH v2 00/11] iommu/tegra241-cmdqv: Fix error-interrupt races and VINTF lifecycle bugs
Date: Tue, 28 Jul 2026 12:15:26 +0100 [thread overview]
Message-ID: <178523230947.340181.5626643238486784200.b4-ty@kernel.org> (raw)
In-Reply-To: <cover.1784059577.git.nicolinc@nvidia.com>
On Tue, 14 Jul 2026 13:54:57 -0700, Nicolin Chen wrote:
> These fix a cluster of bugs reported by Sashiko during patch reviews. The
> patches are ordered roughly most-critical-first, so some later ones fix
> smaller pre-existing issues in the same functions that earlier patches
> touch.
>
> Issues fixed:
> - the error ISR racing VINTF (de)init and reading a NULL, freed, or not
> yet fully initialized slot
> - the probe fallback dereferencing an smmu freed by devm_krealloc()
> - a guest vSID programmed without validating its width or the device's
> Stream ID count
> - VINTF0 leaked on an init-failure path
> - error-map index/bounds handling and a VCMDQ base above the 48-bit limit
> - the error ISR flooding the kernel log under repeated guest errors
>
> [...]
Applied (apart from patch 10) to iommu (arm/smmu/updates), thanks!
[01/11] iommu/tegra241-cmdqv: Publish an LVCMDQ only after it is fully initialized
https://git.kernel.org/iommu/c/cbc41aacd49e
[02/11] iommu/tegra241-cmdqv: Synchronize the error ISR against VINTF (de)init
https://git.kernel.org/iommu/c/a491be376abd
[03/11] iommu/tegra241-cmdqv: Harden error-map index handling in the error ISR
https://git.kernel.org/iommu/c/a2ee315db426
[04/11] iommu/tegra241-cmdqv: Don't run the error ISR before probe sets up vintfs
https://git.kernel.org/iommu/c/5acd67ceb38d
[05/11] iommu/tegra241-cmdqv: Don't fall back to a freed smmu after devm_krealloc()
https://git.kernel.org/iommu/c/d4d05f55e9da
[06/11] iommu/tegra241-cmdqv: Free the error IRQ before tearing down VINTFs
https://git.kernel.org/iommu/c/61f0d437988e
[07/11] iommu/tegra241-cmdqv: Reject a vSID wider than the SID_MATCH field
https://git.kernel.org/iommu/c/4379610c79bd
[08/11] iommu/tegra241-cmdqv: Require exactly one Stream ID for a vSID
https://git.kernel.org/iommu/c/fb292bfc9be9
[09/11] iommu/tegra241-cmdqv: Fix VINTF0 leak on the init-failure path
https://git.kernel.org/iommu/c/f40f31444773
[11/11] iommu/tegra241-cmdqv: Rate-limit the error ISR's log message
https://git.kernel.org/iommu/c/a86c36163c97
Cheers,
--
Will
https://fixes.arm64.dev
https://next.arm64.dev
https://will.arm64.dev
next prev parent reply other threads:[~2026-07-28 11:15 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-14 20:54 Nicolin Chen
2026-07-14 20:54 ` [PATCH v2 01/11] iommu/tegra241-cmdqv: Publish an LVCMDQ only after it is fully initialized Nicolin Chen
2026-07-14 20:54 ` [PATCH v2 02/11] iommu/tegra241-cmdqv: Synchronize the error ISR against VINTF (de)init Nicolin Chen
2026-07-14 20:55 ` [PATCH v2 03/11] iommu/tegra241-cmdqv: Harden error-map index handling in the error ISR Nicolin Chen
2026-07-14 20:55 ` [PATCH v2 04/11] iommu/tegra241-cmdqv: Don't run the error ISR before probe sets up vintfs Nicolin Chen
2026-07-14 20:55 ` [PATCH v2 05/11] iommu/tegra241-cmdqv: Don't fall back to a freed smmu after devm_krealloc() Nicolin Chen
2026-07-14 20:55 ` [PATCH v2 06/11] iommu/tegra241-cmdqv: Free the error IRQ before tearing down VINTFs Nicolin Chen
2026-07-14 20:55 ` [PATCH v2 07/11] iommu/tegra241-cmdqv: Reject a vSID wider than the SID_MATCH field Nicolin Chen
2026-07-14 20:55 ` [PATCH v2 08/11] iommu/tegra241-cmdqv: Require exactly one Stream ID for a vSID Nicolin Chen
2026-07-14 20:55 ` [PATCH v2 09/11] iommu/tegra241-cmdqv: Fix VINTF0 leak on the init-failure path Nicolin Chen
2026-07-14 20:55 ` [PATCH v2 10/11] iommu/tegra241-cmdqv: Warn on a VCMDQ base above the 48-bit hardware limit Nicolin Chen
2026-07-26 12:57 ` Will Deacon
2026-07-26 18:06 ` Nicolin Chen
2026-07-14 20:55 ` [PATCH v2 11/11] iommu/tegra241-cmdqv: Rate-limit the error ISR's log message Nicolin Chen
2026-07-15 17:44 ` [PATCH v2 00/11] iommu/tegra241-cmdqv: Fix error-interrupt races and VINTF lifecycle bugs Nicolin Chen
2026-07-28 11:15 ` Will Deacon [this message]
2026-07-28 16:54 ` Nicolin Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=178523230947.340181.5626643238486784200.b4-ty@kernel.org \
--to=will@kernel.org \
--cc=catalin.marinas@arm.com \
--cc=iommu@lists.linux.dev \
--cc=jgg@ziepe.ca \
--cc=joro@8bytes.org \
--cc=kernel-team@android.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=nicolinc@nvidia.com \
--cc=robin.murphy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®