From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752889AbcB2J5I (ORCPT ); Mon, 29 Feb 2016 04:57:08 -0500 Received: from mout.kundenserver.de ([212.227.126.187]:55344 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750757AbcB2J5E (ORCPT ); Mon, 29 Feb 2016 04:57:04 -0500 From: Arnd Bergmann To: Paul Gortmaker Cc: linux-kernel@vger.kernel.org, Jaegeuk Kim Subject: Re: [PATCH] fs/crypto: make crypto.c explicitly non-modular Date: Mon, 29 Feb 2016 10:56:50 +0100 Message-ID: <17854864.AYbZjbhEmU@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <1456604449-4666-1-git-send-email-paul.gortmaker@windriver.com> References: <1456604449-4666-1-git-send-email-paul.gortmaker@windriver.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:U/oVn5rCTpS4cpB9rBGUUHL67uK8YZu8hLExIQzCdkuic07rmpN 4NXVldiSvUTTkidZ2CK2W3LaYFIVdz1aHbo+btCkzDKSZQd+GynNIouTA0iZne0vHeuXIpO VI4vW2Fgi39YrP1PvvgKImVxvd0WFHHI56VYtdyyFm2pBrJL4Atrbdhte97xkwEchMi1Iu4 b+nDVZEpPjzsQyZMTT2LA== X-UI-Out-Filterresults: notjunk:1;V01:K0:n29RbzO34Do=:jjgnMgX2CCDwZdlu2k6Fl5 KRvxWVYaVfS4eGmw0Cr8xvoO/8R/X4hfvcJeBt4pMO1o1GJgD/W+iDPbQfVXEuCb01Rc1j1kn cTdSzNNTt4IIhFQ0NPXYUs7Ki2XoDezal2NBQouqcQ93NkaoEmugW4M/P5ijbQ3Vior5ZxlD7 k5sBtq9ZOHL2Ub5BVLI2mBC9cisKyMcjNtyeSz52uFJ3FIkKgIshwVqke4SEWTYE7fQ05b7fi fBgX8/kcmXbuizFqOCl4s5y0cDlNsX5oXSXbTuES6ok0xcHCbTFeGrAlTp8khdDYnXE6dhNkV MsAB4KePs4TJQvT5Sm62o3F+j8FYc7vlSUhh7XygtWZgFbypauIYwDCbSGfwwu4ASUkQlgS69 dnry2tulu1RVFWvLOe96IXMYq8aQngBRPa3mL1IL9rgmO8ZkhgbkWx1EdX+K06IJ++9GK2qce VVl4gvi6g0Z/U4pnVlAnAIOZ1Q+ZAjya8FcS227yB7vwwga5eKnZ4e2mFrwQ0I59ecf9WEPib uedN9wuWXvtJ5oo9Zn9c38inL5L1WoYJWhZK6/jYKPrKYxc18UTHMX87+NA+AOXP62eEaP3jx vHSBWBrK2Iv8KiIPWTFoKFPSx/KV2bubAyz2HwkPADA17vignFOHWzAxBxj9avConrDy0reRz zmTuABsY5s7clB1vq21Ck+sOYax4po9nWStEquSZZxflj2fDcVkZrbYgG7TNFLianuBiEGfZZ VPaQkyLWTOCR36e2 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Saturday 27 February 2016 15:20:49 Paul Gortmaker wrote: > As of commit 47134e6084f70fdf4381af75d4569cec6c7ebd50 ("fs crypto: > add Makefile and Kconfig") the compile of fs/crypto/crypto.c tripped > my local audit for non-modules using modular infrastructure vs. their > built in counterparts. > > The Kconfig currently controlling compilation of this code is: > > config FS_ENCRYPTION > bool "FS Encryption (Per-file encryption)" > > combined with: > > obj-$(CONFIG_FS_ENCRYPTION) += crypto.o policy.o keyinfo.o > > ...meaning that it currently is not being built as a module by anyone. > > Lets remove the modular code that is essentially orphaned, so that > when reading the driver there is no doubt it is builtin-only. > > Since module_init translates to device_initcall in the non-modular > case, the use of fs_initcall (which seems appropriate for fs code) > means the init comes slightly earlier. However boot testing an > x86-64 defconfig didn't show this to be causing any issues. > > We replace module.h with moduleparam.h since the file does declare > some module parameters, and leaving them as such is currently the > easiest way to remain compatible with existing boot arg use cases. > So why not make the option a 'tristate' instead? It looks like that was intended here, and we should always try to make all code loadable as modules if possible. Arnd