From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4C4EB3DB64B for ; Fri, 31 Jul 2026 08:32:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785486781; cv=none; b=mXPkEaQvRgVxzHBjSUUa10jtSQkguh7d9Be7HxoUi6cheDw/NlR7+jLfPsYk/L+QYYxU8N4tLttWs0nQXxVv7OteU4wrpcDHrzgFfOkA6jQG7UkRuLcZ2u/zcPed3qPxK5AfmqSq74w8j/ZUG2MU8o6SS8Ct/HUlmtxC5swFrH4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785486781; c=relaxed/simple; bh=U1LozG4rZEEjWVwQ3I7ZFVikTNJQv6vZJq2l659olmA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=kvzfebhlJ6O5YNDAUMigwt1KO5734l3H2wdpbZ0pXB5mt09+9XSCZrkiaXlioix7TuhdODdbgRekcGEOIZvAKU7lrhymmW2p2VQJ8yrS9b+3ev2Myttg/a1L4XngSht3fqv3ZzHtXx/KhKw3AiRwsYF8BBXJNkWQmd6IVEYsCFE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ChjfycUc; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=ksEvyWR7; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ChjfycUc"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="ksEvyWR7" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66V8MXRK3744952 for ; Fri, 31 Jul 2026 08:32:58 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 6EGfAxtNNH/KIZ1TzK6fLYayMFk1+xfs+0d3KiAm9GU=; b=ChjfycUc9iL4SIrP 4qoSSUu6u/m2kgOu5+cYUNDxYeqnmqgvOVCjdyL7ChAuEKViLqHAccBRy0WPuPbL gCYpo7dLiKYw1iw+YiTxoy5jOYbxvxwIecwXnf4nPnogn+/3zmAdxPIcXuSaFFcr fbIK01FwPBCFRIfRgdItD1H9CmXAgGu0oxxCWD1uHqU6yhYgVoDJsIg1UjPE8YR5 /hC3kdiVn/GJZuUv4I89g8+WQNRKWuofE1A/m+cd1r64kdls12ZnyK8Hhl9JD/Me CDQlEopNtuWRUbIomfXrtNfQU1eAbCIoe+su51K1rlVu1PQQe6B/75TYgRsCW1KT oGrRLw== Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4frr4wg183-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 31 Jul 2026 08:32:57 +0000 (GMT) Received: by mail-qt1-f198.google.com with SMTP id d75a77b69052e-51c12e43b98so6369101cf.1 for ; Fri, 31 Jul 2026 01:32:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1785486777; x=1786091577; darn=vger.kernel.org; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to:content-type; bh=6EGfAxtNNH/KIZ1TzK6fLYayMFk1+xfs+0d3KiAm9GU=; b=ksEvyWR78ry0QaPd6B3nvBv6EZyrom0lop09n9Ht9EjQ+xr9yyKJQLOtQPJXZMatNY ovKMXafAbwPE8M9c6Lenijws7kyJOm0mvbuXNTEzGUEDTSWoo1YnO0y+bkAy0WoEbXK5 adnTEDDh/9Blk1lApkA9iTxEBobqeTlxcaoGDG0EmDL2bodMMjNWcP35wKg5eVCL1XwR mzyBn5Hls3SDZSfsmy6cmWCcUXfugCgFZILOqRdepb3l5MJJp1V8rIMhC3sqlMoIO8K6 DDOl0UFAveyPT0W3E6tbbwEiEBBRZWka/hFk96HdS/kpO0/OYas3Dsn+eEKzJsr12xbk GQUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785486777; x=1786091577; h=content-transfer-encoding:content-type:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to :content-type; bh=6EGfAxtNNH/KIZ1TzK6fLYayMFk1+xfs+0d3KiAm9GU=; b=NoHUzM6ZYyXTvVhJPPs5fx8YWteIY6AOAtnS7dwL+DOAFH/wAiYo3Qfn+KTYdvjUcE 9+yU/zkEd+SjAZaBqVFLleKv+WrtIWRhQZsq8Ch9XfiLIII65Hc0ggMMH6Y+bz4Mn3jq /dRdYDFTpTL5Yek30130xmP0Px3HVJZ3ozBy1tPkfNLDBWKh5g7YL/v5uBK06DVgo5v9 IeR3bd/jBBTVExy7DJ7KNd3ZpMy67vVqP4HZZUpwBC4R6XO8YDXszsKV6/7h7pqSb0Y1 B3ToPo4t4+3N72ae0QjyJGpMFwPXnDwELaV8tQkDzv+9CQpH76P5xoLfByrlReEJhFm7 KHDw== X-Forwarded-Encrypted: i=1; AHgh+RrB59XBbL5M0ujqRkDWvlux8ma3bRO9rJM5N2Q/gdYoI32hxxoNxIGYg3+wz4g/tP2YOxAAQNC5sslqyQg=@vger.kernel.org X-Gm-Message-State: AOJu0YwcVhMHmebAN268zMKqRteiXRknIe9JhKrPBeJLJqOZJ0/ECeQx cKIxXxnJkuvLDzyqyEBTrY9zAQHGU6x+x5AIEck/MjNKv/2fi2//L6EnhbMOri7Lmi7Gl9R4yrN GuPJyy1fb9poQIOYb8AizBOeOy5egE4sHKI/J45MPnLz+d1umIBNvH4K7zyV1DkEoMXY= X-Gm-Gg: AR+sD12XhoZTAHuj87c4Y0dO5nbWGhdCYvMSBdwfRrVCf0pcPjC4F2ARvomqjZ895UY x9P8B7Pze+tt6aqHBRKnfhr4UeObPegs42/+TYmT0m/dICHKmJiLWl/kclX6p5+dvKWpv5Vk/IZ FBRzALwctij/TAum2W8uKsTkNp+HiwRtrofmsddHasS0ukoSMWs6YHfwHmJcEaE/iAG6ptXMMgH Bb+azguquUG2zmVItOBH9VvpX1HnfyuM4yk2BWh5GxEtLfr13uXHAYycgC80Wr1tBmtAh+EpziS g95zBDrdchEOde1Aq0Srer3DST1JDYOPRYtjnzdm6bdS/WUt1zDt+GWHWZyXLMNaol6FACd+fCA B5tpyRE+jQ53lGpYBMoEXlWAvb2BP X-Received: by 2002:ac8:58c4:0:b0:51c:22c5:daee with SMTP id d75a77b69052e-52b4af4ffddmr11381551cf.29.1785486777225; Fri, 31 Jul 2026 01:32:57 -0700 (PDT) X-Received: by 2002:ac8:58c4:0:b0:51c:22c5:daee with SMTP id d75a77b69052e-52b4af4ffddmr11381411cf.29.1785486776791; Fri, 31 Jul 2026 01:32:56 -0700 (PDT) Received: from brgl-qcom.home ([2a01:cb1d:dc:7e00:40fa:e8e6:4785:ce70]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c1fd3c5b4d4sm68887466b.3.2026.07.31.01.32.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 31 Jul 2026 01:32:55 -0700 (PDT) From: Bartosz Golaszewski To: RAGUENES Jean Noel , Linus Walleij , Bartosz Golaszewski , "Christophe Leroy (CS GROUP)" Cc: Bartosz Golaszewski , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] gpiolib: Check gc->get_direction() before calling gpiod_get_direction() Date: Fri, 31 Jul 2026 10:32:53 +0200 Message-ID: <178548677168.77960.15544843581885268419.b4-ty@oss.qualcomm.com> X-Mailer: git-send-email 2.47.3 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit X-Proofpoint-GUID: PUeU7uLgJvK0zWIkmULY2n-JgqY1tOSN X-Proofpoint-Spam-Info: AW1haW4tMjYwNzMxMDA2MSBTYWx0ZWRfX5JoD2churSen mVsAps/VX7iTbX3cZgeRm2iXYJ1Jr7CTSIUpJECRo78AxeoO7FJ4Lkcp+k6YE8FLeF9fKQb/GAc UWfDBMOBVsILObd3IPlccVNkcxF/llQ= X-Authority-Analysis: v=2.4 cv=D4Z37PRj c=1 sm=1 tr=0 ts=6a6c5dba cx=c_pps a=mPf7EqFMSY9/WdsSgAYMbA==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=6wOr4KMY0LgiFmB2x94A:9 a=QEXdDO2ut3YA:10 a=zZCYzV9kfG8A:10 a=dawVfQjAaf238kedN5IG:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzMxMDA2MSBTYWx0ZWRfX/UteCmUXAEBy axQyi78cDXNLaWbloMqzGr63AEPR4ylgyCPYJQoYuypFgWmX9/jNPHZOMOdHj6mz4lG6aMd3nd9 yLkg3YPZHZ50PZ+V1bIZNQ/KaEpsfRUYPJJgZCwGWfqO9U0zsQrdZeFPiaNMH6HgAZjVZdNCPmk LX9SEGbRyasJAGUnn+MeyDfw3ueV5nf9WD870kE8jFx55bXl6MCoEhMlpqKDo6Mc+Wx/atZ7WCt pmdZX/6jtm3nakS9xKqcsSMmAogNhyPe+XOFbC/xBPmbzuVytsPJIk3xfcUnyHoXnxSddJg9pBz +xLe6EFvnWrBicHr0qcXcUPchUn8c5Ziy8pcEScx59JCD+xVzMA9FTRFA7I3pFgoPfIvDiX7BIt eQN4XIuRJLZfTTeH00vbsierH1Lk+AUjL55VkmfzibSbku8qC7s8Tw0yfK2REvZ6whmIl9PIVlr zdoTkaxj+wPSODCkOTQ== X-Proofpoint-ORIG-GUID: PUeU7uLgJvK0zWIkmULY2n-JgqY1tOSN X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-31_03,2026-07-30_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 adultscore=0 suspectscore=0 phishscore=0 lowpriorityscore=0 malwarescore=0 spamscore=0 priorityscore=1501 impostorscore=0 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607310061 On Wed, 29 Jul 2026 11:47:20 +0200, Christophe Leroy (CS GROUP) wrote: > According to 'struct gpio_chip' documentation in linux/gpio/driver.h, > implementing .get_direction() is recommended but not mandatory. > Most places verify that gc->get_direction() exists before calling > gpiod_get_direction(), but gpiolib_dbg_show() doesn't. > > Until commit 471e998c0e31 ("gpiolib: remove redundant callback check") > it was also verified by gpiod_get_direction() itself so calling it at > all time from gpiolib_dbg_show() was not an issue. But after the check > in gpiod_get_direction() has been removed, calling it inconditionaly > leads to a big fat warning in gpiochip_get_direction(). > > [...] Applied, thanks! [1/1] gpiolib: Check gc->get_direction() before calling gpiod_get_direction() https://git.kernel.org/brgl/c/d761c7e38a000603a9d16270a1af770a0e8efb5e Best regards, -- Bartosz Golaszewski