From: Namhyung Kim <namhyung@kernel.org>
To: Arnaldo Carvalho de Melo <acme@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
Michael Liang <mliang@purestorage.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Jiri Olsa <jolsa@kernel.org>, Ian Rogers <irogers@google.com>,
Adrian Hunter <adrian.hunter@intel.com>,
James Clark <james.clark@linaro.org>,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] perf libdw: Fix outer-frame name resolution and spurious "(inlined)" tag
Date: Sat, 01 Aug 2026 22:46:31 -0700 [thread overview]
Message-ID: <178564959160.665203.11205263654322678583.b4-ty@kernel.org> (raw)
In-Reply-To: <20260728204215.327318-2-mliang@purestorage.com>
On Tue, 28 Jul 2026 14:42:15 -0600, Michael Liang wrote:
> cu_walk_functions_at() calls libdw_a2l_cb() with the containing
> DW_TAG_subprogram DIE first, then each DW_TAG_inlined_subroutine
> nested inside. The callback treated both the same way, causing two
> bugs:
>
> 1) die_name() returns the unqualified DW_AT_name, so every C++
> frame lost its namespace/class prefix (ns::Class::method
> collapsed to method).
>
> [...]
Applied to perf-tools-next, thanks!
Best regards,
Namhyung
prev parent reply other threads:[~2026-08-02 5:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-28 20:42 [PATCH 0/1] perf libdw: fix outer-frame name " Michael Liang
2026-07-28 20:42 ` [PATCH 1/1] perf libdw: Fix outer-frame name resolution " Michael Liang
2026-07-29 10:21 ` James Clark
2026-08-02 5:46 ` Namhyung Kim [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=178564959160.665203.11205263654322678583.b4-ty@kernel.org \
--to=namhyung@kernel.org \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=irogers@google.com \
--cc=james.clark@linaro.org \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=mliang@purestorage.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®