From: Neil Brown <neilb@suse.de>
To: "Jesper Juhl" <jesper.juhl@gmail.com>
Cc: "Trond Myklebust" <trond.myklebust@fys.uio.no>,
nfs@lists.sourceforge.net,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>
Subject: Re: [NFS] 2.6.17.8 - do_vfs_lock: VFS is out of sync with lock manager!
Date: Fri, 2 Feb 2007 09:39:21 +1100 [thread overview]
Message-ID: <17858.27673.476380.463938@notabene.brown> (raw)
In-Reply-To: message from Jesper Juhl on Wednesday January 31
On Wednesday January 31, jesper.juhl@gmail.com wrote:
> On 29/01/07, Trond Myklebust <trond.myklebust@fys.uio.no> wrote:
>
> Finally getting that in will be sooooo nice :-) Thank you.
>
> Btw: any reason why not to include the
> fl->fl_flags &= ~FL_SLEEP;
> bit as well? As in http://lkml.org/lkml/2006/11/27/41 ??
>
Uhmm... I guess I had forgotten it ....
Looking again, I cannot convince myself that it is needed.
The comment says "If we were signalled ...", and if we were signalled
then do_vfs_lock won't block anyway. I think I was probably being
over-cautious as I didn't know the significance of testing for
-ERESTARTSYS.
However it seems to only get returned if a signal is pending (so why
EINTR isn't returned I still don't know) so a signal must be pending
on that piece of code, so there is no need to clear FL_SLEEP.
Thanks,
NeilBrown
prev parent reply other threads:[~2007-02-01 22:39 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-08 14:39 Jesper Juhl
2006-08-09 5:53 ` Grant Coady
2006-08-09 8:07 ` Jesper Juhl
2006-08-10 22:37 ` Jesper Juhl
2006-08-11 0:30 ` Grant Coady
2006-08-13 23:08 ` Grant Coady
2006-08-17 6:49 ` [NFS] " Neil Brown
2006-08-17 9:58 ` Jesper Juhl
2006-08-21 3:34 ` Neil Brown
2006-08-21 19:54 ` Trond Myklebust
2006-11-21 12:43 ` Jesper Juhl
2006-11-27 9:19 ` Jesper Juhl
2007-01-29 5:08 ` Neil Brown
2007-01-29 14:16 ` Trond Myklebust
2007-01-30 23:42 ` Jesper Juhl
2007-02-01 22:39 ` Neil Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17858.27673.476380.463938@notabene.brown \
--to=neilb@suse.de \
--cc=jesper.juhl@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nfs@lists.sourceforge.net \
--cc=trond.myklebust@fys.uio.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome