From: Leon Romanovsky <leon@kernel.org>
To: linux-rdma@vger.kernel.org, Yehyeong Lee <yhlee@isslab.korea.ac.kr>
Cc: bvanassche@acm.org, jgg@ziepe.ca, linux-kernel@vger.kernel.org,
stable@vger.kernel.org
Subject: Re: [PATCH] RDMA/srp: fix heap information leak on a truncated SRP_CRED_REQ
Date: Wed, 05 Aug 2026 11:05:48 -0400 [thread overview]
Message-ID: <178594234881.4143885.2201729230389309180.b4-ty@kernel.org> (raw)
In-Reply-To: <20260729093203.1503201-1-yhlee@isslab.korea.ac.kr>
On Wed, 29 Jul 2026 18:32:03 +0900, Yehyeong Lee wrote:
> srp_recv_done() passes wc->byte_len to srp_process_rsp(). It passes
> nothing to srp_process_cred_req() and srp_process_aer_req(), which read
> fixed-size fields from the receive buffer without checking that those
> fields were received.
>
> The buffer size is max_ti_iu_len, which comes from the login response
> and is not validated. A target that advertises 8 and then sends an
> 8-byte SRP_CRED_REQ makes the initiator read req->tag from beyond the
> end of the buffer. req->tag is copied into the SRP_CRED_RSP and sent
> back, so those bytes reach the target. SRP_AER_REQ behaves the same way
> and also reads req->lun.
>
> [...]
Applied, thanks!
[1/1] RDMA/srp: fix heap information leak on a truncated SRP_CRED_REQ
https://git.kernel.org/rdma/rdma/c/961ac0f0c5e414
Best regards,
--
Leon Romanovsky <leon@kernel.org>
prev parent reply other threads:[~2026-08-05 15:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-29 9:32 Yehyeong Lee
2026-07-30 18:32 ` Bart Van Assche
2026-08-05 15:05 ` Leon Romanovsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=178594234881.4143885.2201729230389309180.b4-ty@kernel.org \
--to=leon@kernel.org \
--cc=bvanassche@acm.org \
--cc=jgg@ziepe.ca \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=yhlee@isslab.korea.ac.kr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®