From: Lee Jones <lee@kernel.org>
To: Janne Grunau <j@jannau.net>, Neal Gompa <neal@gompa.dev>,
Lee Jones <lee@kernel.org>, Sven Peter <sven@kernel.org>
Cc: asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, kernel test robot <lkp@intel.com>
Subject: Re: (subset) [PATCH] mfd: macsmc: Fix key count endianness annotation
Date: Thu, 06 Aug 2026 14:27:50 +0100 [thread overview]
Message-ID: <178602287064.2920636.6724369399863023902.b4-ty@b4> (raw)
In-Reply-To: <20260719-b4-macsmc-be32-fix-v1-1-c7b1936307fa@kernel.org>
On Sun, 19 Jul 2026 15:00:32 +0200, Sven Peter wrote:
> SMC firmware returns the value of the #KEY key in big-endian unlike most
> other keys. Reading it through apple_smc_read_u32() into a plain u32
> and then converting with be32_to_cpu() makes sparse complain:
>
> drivers/mfd/macsmc.c:462:26: sparse: cast to restricted __be32
>
> Read the raw value into a __be32 using apple_smc_read() instead.
>
> [...]
Applied, thanks!
[1/1] mfd: macsmc: Fix key count endianness annotation
commit: 0a29aa605286bcd01632eb6b61f59b9053312347
--
Lee Jones [李琼斯]
prev parent reply other threads:[~2026-08-06 13:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-19 13:00 Sven Peter
2026-07-19 15:02 ` Joshua Peisach
2026-07-19 15:15 ` Sven Peter
2026-07-19 15:28 ` Joshua Peisach
2026-07-22 10:03 ` Janne Grunau
2026-08-06 13:27 ` Lee Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=178602287064.2920636.6724369399863023902.b4-ty@b4 \
--to=lee@kernel.org \
--cc=asahi@lists.linux.dev \
--cc=j@jannau.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=neal@gompa.dev \
--cc=sven@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®