From: Vinod Koul <vkoul@kernel.org>
To: Neil Armstrong <neil.armstrong@linaro.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Magnus Damm <magnus.damm@gmail.com>,
Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>,
Felix Gu <ustc.gu@gmail.com>
Cc: linux-phy@lists.infradead.org, linux-renesas-soc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] phy: renesas: rcar-gen2: Fix double of_node_put on phy creation failure
Date: Thu, 06 Aug 2026 21:56:22 +0530 [thread overview]
Message-ID: <178603358234.674490.1366685578663811310.b4-ty@kernel.org> (raw)
In-Reply-To: <20260803-rcar-gen2-v1-1-9aa35c36d7d7@gmail.com>
On Mon, 03 Aug 2026 20:43:24 +0800, Felix Gu wrote:
> for_each_child_of_node_scoped() releases the node reference on scope
> exit, so the explicit of_node_put(np) in the devm_phy_create() error
> path drops it twice.
>
> Drop the redundant of_node_put() and let the scoped cleanup handle it.
>
>
> [...]
Applied, thanks!
[1/1] phy: renesas: rcar-gen2: Fix double of_node_put on phy creation failure
commit: b780b8929c759cfa7a892d58625a5ad46cb1cbd2
Best regards,
--
~Vinod
prev parent reply other threads:[~2026-08-06 16:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-03 12:43 Felix Gu
2026-08-03 13:09 ` Krzysztof Kozlowski
2026-08-03 13:21 ` Biju Das
2026-08-06 16:26 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=178603358234.674490.1366685578663811310.b4-ty@kernel.org \
--to=vkoul@kernel.org \
--cc=geert+renesas@glider.be \
--cc=krzysztof.kozlowski@oss.qualcomm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=neil.armstrong@linaro.org \
--cc=ustc.gu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®