From: Carlos Maiolino <cem@kernel.org>
To: Yun Zhou <yun.zhou@windriver.com>
Cc: hch@lst.de, djwong@kernel.org, linux-xfs@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] xfs: restore nofs context unconditionally in xfs_trans_roll
Date: Mon, 10 Aug 2026 13:55:35 +0200 [thread overview]
Message-ID: <178636293501.58486.13061127606354356864.b4-ty@kernel.org> (raw)
In-Reply-To: <20260730093002.1034320-1-yun.zhou@windriver.com>
On Thu, 30 Jul 2026 17:30:02 +0800, Yun Zhou wrote:
> When __xfs_trans_commit() fails in xfs_trans_roll(), the NOFS context
> is cleared but only restored in the success path. This leaves the
> error path without nofs protection, causing a circular lock dependency
> between xfs_nondir_ilock_class and fs_reclaim:
>
> CPU0 CPU1
> ---- ----
> lock(&xfs_nondir_ilock_class);
> lock(fs_reclaim);
> lock(&xfs_nondir_ilock_class);
> lock(fs_reclaim);
>
> [...]
Applied to for-next, thanks!
[1/1] xfs: restore nofs context unconditionally in xfs_trans_roll
commit: 0241ea5fb0fe86d2a673163b2f5815111aadc7f7
Best regards,
--
Carlos Maiolino <cem@kernel.org>
prev parent reply other threads:[~2026-08-10 11:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-30 9:30 Yun Zhou
2026-07-30 11:24 ` Christoph Hellwig
2026-07-30 15:51 ` Darrick J. Wong
2026-08-10 11:55 ` Carlos Maiolino [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=178636293501.58486.13061127606354356864.b4-ty@kernel.org \
--to=cem@kernel.org \
--cc=djwong@kernel.org \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=yun.zhou@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®