From: Carlos Maiolino <cem@kernel.org>
To: djwong@kernel.org, leo.lilong@huawei.com, bfoster@redhat.com,
Hongling Zeng <zenghongling@kylinos.cn>
Cc: linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org,
zhongling0719@126.com, stable@vger.kernel.org
Subject: Re: [PATCH] xfs: validate attr entry pointer before field access
Date: Mon, 10 Aug 2026 13:55:40 +0200 [thread overview]
Message-ID: <178636294070.58486.5392695616314292202.b4-ty@kernel.org> (raw)
In-Reply-To: <20260728074340.84166-1-zenghongling@kylinos.cn>
On Tue, 28 Jul 2026 15:43:40 +0800, Hongling Zeng wrote:
> xfs_attr3_leaf_verify_entry() accesses lentry/rentry fields (namelen,
> valuelen) before checking if the entry pointer itself is within bounds.
> If nameidx is crafted to point near the end of the buffer, these field
> accesses can read out-of-bounds before the bounds check at
> name_end > buf_end is performed.
>
> Add explicit bounds checks for entry pointers before accessing their
> fields. Use offsetof() to check that the start of the flexible array
> member (nameval/name) is within bounds, which ensures all preceding
> fields are safe to access.
>
> [...]
Applied to for-next, thanks!
[1/1] xfs: validate attr entry pointer before field access
commit: b7eea80be25f3334f131d52982b3131aba77b97d
Best regards,
--
Carlos Maiolino <cem@kernel.org>
prev parent reply other threads:[~2026-08-10 11:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-28 7:43 Hongling Zeng
2026-07-28 15:12 ` Darrick J. Wong
2026-08-10 11:55 ` Carlos Maiolino [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=178636294070.58486.5392695616314292202.b4-ty@kernel.org \
--to=cem@kernel.org \
--cc=bfoster@redhat.com \
--cc=djwong@kernel.org \
--cc=leo.lilong@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=zenghongling@kylinos.cn \
--cc=zhongling0719@126.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®