From: Bjorn Andersson <andersson@kernel.org>
To: Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Brian Masney <bmasney@redhat.com>,
Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>,
Taniya Das <taniya.das@oss.qualcomm.com>,
Abel Vesa <abel.vesa@oss.qualcomm.com>,
Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>,
Vivek Aknurwar <vivek.aknurwar@oss.qualcomm.com>,
Mike Tipton <mike.tipton@oss.qualcomm.com>,
Luca Weiss <luca.weiss@fairphone.com>
Cc: ~postmarketos/upstreaming@lists.sr.ht,
phone-devel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH RFT 0/3] Fix always-enabling PCIE_RSCC clocks for multiple clk drivers
Date: Mon, 10 Aug 2026 13:45:59 -0500 [thread overview]
Message-ID: <178638756034.656675.3330999499469928207.b4-ty@kernel.org> (raw)
In-Reply-To: <20260807-various-pcie-clk-fix-v1-0-5caf78a599d7@fairphone.com>
On Fri, 07 Aug 2026 09:46:03 +0200, Luca Weiss wrote:
> I've noticed that the .clk_cbcrs list in multiple clock drivers enable
> the GCC_PCIE_RSCC_CFG_AHB_CLK and GCC_PCIE_RSCC_XO_CLK wrongly.
>
> qcom_branch_set_clk_en() will be called on each entry which will set
> BIT(0) to enable the clock, but this is wrong for these two clocks which
> -- this is also why this is marked RFT -- at least for kaanapali
> needs BIT(20) and BIT(21) set to enable them.
>
> [...]
Applied, thanks!
[1/3] clk: qcom: gcc-eliza: Fix always-enabling PCIE_RSCC clocks
commit: 34e0ef622cd41eb5ee77d6aae79276c12de7c20f
[2/3] clk: qcom: gcc-hawi: Fix always-enabling PCIE_RSCC clocks
commit: c83e1427064e6fe95604b469f4c670e1839f409a
[3/3] clk: qcom: gcc-kaanapali: Fix always-enabling PCIE_RSCC clocks
commit: 7f6869e53f73c4ca0e622a6a1b5ac2598fee5931
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
next prev parent reply other threads:[~2026-08-10 18:46 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-07 7:46 Luca Weiss
2026-08-07 7:46 ` [PATCH RFT 1/3] clk: qcom: gcc-eliza: Fix always-enabling PCIE_RSCC clocks Luca Weiss
2026-08-10 12:06 ` Abel Vesa
2026-08-07 7:46 ` [PATCH RFT 2/3] clk: qcom: gcc-hawi: " Luca Weiss
2026-08-07 7:46 ` [PATCH RFT 3/3] clk: qcom: gcc-kaanapali: " Luca Weiss
2026-08-10 18:45 ` Bjorn Andersson [this message]
2026-08-31 20:21 ` [PATCH RFT 0/3] Fix always-enabling PCIE_RSCC clocks for multiple clk drivers Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=178638756034.656675.3330999499469928207.b4-ty@kernel.org \
--to=andersson@kernel.org \
--cc=abel.vesa@oss.qualcomm.com \
--cc=bmasney@redhat.com \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luca.weiss@fairphone.com \
--cc=mike.tipton@oss.qualcomm.com \
--cc=mturquette@baylibre.com \
--cc=phone-devel@vger.kernel.org \
--cc=sboyd@kernel.org \
--cc=taniya.das@oss.qualcomm.com \
--cc=vivek.aknurwar@oss.qualcomm.com \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®