mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Namhyung Kim <namhyung@kernel.org>
To: acme@kernel.org, Ian Rogers <irogers@google.com>
Cc: adrian.hunter@intel.com, alice.mei.rogers@gmail.com,
	 dapeng1.mi@linux.intel.com, james.clark@linaro.org,
	leo.yan@linux.dev,  linux-kernel@vger.kernel.org,
	linux-perf-users@vger.kernel.org,  mingo@redhat.com,
	peterz@infradead.org, tmricht@linux.ibm.com
Subject: Re: [PATCH v3 00/15] perf python: Fix python extension bugs from v19 review
Date: Tue, 11 Aug 2026 17:52:16 -0700	[thread overview]
Message-ID: <178649593632.2880647.4424444661810354972.b4-ty@kernel.org> (raw)
In-Reply-To: <20260809071455.1221514-1-irogers@google.com>

On Sun, 09 Aug 2026 00:14:39 -0700, Ian Rogers wrote:
> Phase 1 of splitting the v19 review patches into smaller fixes.
> These patches address issues identified in the python extension during
> the review of the v19 script porting series, as well as fixing several
> pre-existing bugs and leaks.
> 
> v3:
> - Addressed review feedback from Namhyung Kim and Sashiko AI:
>   - Dropped "perf data: Fix directory file descriptor leak in perf_data__switch"
>     to avoid Use-After-Free during directory mode file rotation.
>   - Added list == NULL check in pyrf_counts_values_set_values to safely
>     handle attribute deletion (del obj.values).
>   - Preserved errno before calling intlist__delete(skiplist) in cmd_test
>     error path to prevent clobbering the return error code.
>   - Added CHECK_INITIALIZED to pyrf_pmu__repr to prevent NULL pointer
>     dereferences on uninitialized PMU objects.
>   - Fixed duplicate patch title from v2.
> 
> [...]
Applied to perf-tools-next, thanks!

Best regards,
Namhyung



      parent reply	other threads:[~2026-08-12  0:52 UTC|newest]

Thread overview: 53+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-23  5:35 [PATCH v1 00/13] perf python: Fix python extension bugs and memory leaks Ian Rogers
2026-06-23  5:35 ` [PATCH v1 01/13] perf script: Fix metric_evlist leak in script_find_metrics Ian Rogers
2026-06-23  5:35 ` [PATCH v1 02/13] perf stat: Fix evsel_list leak in cmd_stat Ian Rogers
2026-06-23  5:35 ` [PATCH v1 03/13] perf top: Fix sb_evlist leak Ian Rogers
2026-06-23  5:35 ` [PATCH v1 04/13] perf python: Fix memory leak in pyrf_evlist__get_pollfd Ian Rogers
2026-06-23  5:35 ` [PATCH v1 05/13] perf synthetic-events: Fix uninitialized pthread_join Ian Rogers
2026-06-23  5:35 ` [PATCH v1 06/13] perf data: Fix directory file descriptor leak in perf_data__switch Ian Rogers
2026-06-23  5:35 ` [PATCH v1 07/13] perf test: Fix skiplist leak in cmd_test Ian Rogers
2026-06-23  5:35 ` [PATCH v1 08/13] perf python: Check counts_values size in set_values Ian Rogers
2026-06-23  5:35 ` [PATCH v1 09/13] perf python: Validate CPU and thread maps in pyrf_evsel__open Ian Rogers
2026-06-23  5:35 ` [PATCH v1 10/13] perf python: Validate attribute setters in pyrf_evsel Ian Rogers
2026-06-23  5:35 ` [PATCH v1 11/13] perf python: Zero initialize perf_data in pyrf_data__init Ian Rogers
2026-06-23  5:35 ` [PATCH v1 12/13] perf python: Add thread uninitialized checks Ian Rogers
2026-06-23  5:35 ` [PATCH v1 13/13] perf python: Fix MetricGroup return type in perf.pyi Ian Rogers
2026-06-24  5:15 ` [PATCH v2 00/16] perf python: Fix python extension bugs from v19 review Ian Rogers
2026-06-24  5:15   ` [PATCH v2 01/16] perf script: Fix metric_evlist leak in script_find_metrics Ian Rogers
2026-06-24  5:15   ` [PATCH v2 02/16] perf stat: Fix evsel_list leak in cmd_stat Ian Rogers
2026-06-24  5:15   ` [PATCH v2 03/16] perf tools: Fix sb_evlist leaks in top and record Ian Rogers
2026-06-24  5:15   ` [PATCH v2 03/16] perf top: Fix sb_evlist leak Ian Rogers
2026-07-04 16:55     ` Namhyung Kim
2026-06-24  5:15   ` [PATCH v2 04/16] perf python: Fix memory leak in pyrf_evlist__get_pollfd Ian Rogers
2026-06-24  5:15   ` [PATCH v2 05/16] perf synthetic-events: Fix uninitialized pthread_join Ian Rogers
2026-06-24  5:15   ` [PATCH v2 06/16] perf data: Fix directory file descriptor leak in perf_data__switch Ian Rogers
2026-06-24  5:15   ` [PATCH v2 07/16] perf test: Fix skiplist leak in cmd_test Ian Rogers
2026-06-24  5:15   ` [PATCH v2 08/16] perf python: Check counts_values size in set_values Ian Rogers
2026-06-24  5:15   ` [PATCH v2 09/16] perf python: Validate CPU and thread maps in pyrf_evsel__open Ian Rogers
2026-06-24  5:15   ` [PATCH v2 10/16] perf python: Validate attribute setters in pyrf_evsel Ian Rogers
2026-06-24  5:15   ` [PATCH v2 11/16] perf python: Zero initialize perf_data in pyrf_data__init Ian Rogers
2026-06-24  5:15   ` [PATCH v2 12/16] perf python: Add thread and PMU uninitialized checks Ian Rogers
2026-06-24  5:15   ` [PATCH v2 13/16] perf python: Fix MetricGroup return type in perf.pyi Ian Rogers
2026-06-24  5:15   ` [PATCH v2 14/16] perf python: Fix count_values memory leak in pyrf_evsel__read Ian Rogers
2026-06-24  5:15   ` [PATCH v2 15/16] perf python: Fix memory leak in pyrf__metrics_cb Ian Rogers
2026-06-24  5:15   ` [PATCH v2 16/16] perf synthetic-events: Fix divide by zero in perf_event__synthesize_threads Ian Rogers
2026-07-04 16:54   ` [PATCH v2 00/16] perf python: Fix python extension bugs from v19 review Namhyung Kim
2026-07-04 23:03     ` Ian Rogers
2026-07-06 23:49       ` Namhyung Kim
2026-08-09  7:14   ` [PATCH v3 00/15] " Ian Rogers
2026-08-09  7:14     ` [PATCH v3 01/15] perf script: Fix metric_evlist leak in script_find_metrics Ian Rogers
2026-08-09  7:14     ` [PATCH v3 02/15] perf stat: Fix evsel_list leak in cmd_stat Ian Rogers
2026-08-09  7:14     ` [PATCH v3 03/15] perf tools: Fix sb_evlist leaks in top and record Ian Rogers
2026-08-09  7:14     ` [PATCH v3 04/15] perf python: Fix memory leak in pyrf_evlist__get_pollfd Ian Rogers
2026-08-09  7:14     ` [PATCH v3 05/15] perf synthetic-events: Fix uninitialized pthread_join Ian Rogers
2026-08-09  7:14     ` [PATCH v3 06/15] perf test: Fix skiplist leak in cmd_test Ian Rogers
2026-08-09  7:14     ` [PATCH v3 07/15] perf python: Check counts_values size in set_values Ian Rogers
2026-08-09  7:14     ` [PATCH v3 08/15] perf python: Validate CPU and thread maps in pyrf_evsel__open Ian Rogers
2026-08-09  7:14     ` [PATCH v3 09/15] perf python: Validate attribute setters in pyrf_evsel Ian Rogers
2026-08-09  7:14     ` [PATCH v3 10/15] perf python: Zero initialize perf_data in pyrf_data__init Ian Rogers
2026-08-09  7:14     ` [PATCH v3 11/15] perf python: Add thread and PMU uninitialized checks Ian Rogers
2026-08-09  7:14     ` [PATCH v3 12/15] perf python: Fix MetricGroup return type in perf.pyi Ian Rogers
2026-08-09  7:14     ` [PATCH v3 13/15] perf python: Fix count_values memory leak in pyrf_evsel__read Ian Rogers
2026-08-09  7:14     ` [PATCH v3 14/15] perf python: Fix memory leak in pyrf__metrics_cb Ian Rogers
2026-08-09  7:14     ` [PATCH v3 15/15] perf synthetic-events: Fix divide by zero in perf_event__synthesize_threads Ian Rogers
2026-08-12  0:52     ` Namhyung Kim [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=178649593632.2880647.4424444661810354972.b4-ty@kernel.org \
    --to=namhyung@kernel.org \
    --cc=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=alice.mei.rogers@gmail.com \
    --cc=dapeng1.mi@linux.intel.com \
    --cc=irogers@google.com \
    --cc=james.clark@linaro.org \
    --cc=leo.yan@linux.dev \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=tmricht@linux.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®