mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Chuck Lever <cel@kernel.org>
To: jlayton@kernel.org, neil@brown.name, okorniev@redhat.com,
	Dai.Ngo@oracle.com, tom@talpey.com,
	Ameer Hamza <ameer.hamza@truenas.com>
Cc: linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org,
	alexander.motin@truenas.com, caleb.stjohn@truenas.com
Subject: Re: [PATCH v2 0/2] sunrpc: don't strip a uid's groups when the mountd group lookup fails
Date: Sat, 15 Aug 2026 12:24:20 -0400	[thread overview]
Message-ID: <178681105303.93379.12774054259768112149.b4-ty@b4> (raw)
In-Reply-To: <20260814221953.108837-1-ameer.hamza@truenas.com>

On Sat, 15 Aug 2026 03:19:51 +0500, Ameer Hamza wrote:
> On a server running rpc.mountd with --manage-gids, a transient
> name-service failure makes mountd answer the auth.unix.gid upcall
> with a zero-group reply, which the kernel installs as a valid
> positive entry.  Patch 1 records such replies as negative entries
> on the classic /proc channel, so the credential keeps the groups
> it already carries.  Patch 2 does the same for the netlink upcall,
> which has an explicit NEGATIVE flag the parser does not propagate.
> 
> [...]

Applied to nfsd-testing, thanks!

[1/2] sunrpc: treat empty auth.unix.gid replies as negative entries
      commit: e865ae50d85a5585eb29cd67dfb0f776da1aa0c9
[2/2] sunrpc: honor the netlink unix_gid NEGATIVE flag
      commit: 76427d869120552a1a82e1f1488d9f8311827d84

--
Chuck Lever


      parent reply	other threads:[~2026-08-15 16:24 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-14 22:19 Ameer Hamza
2026-08-14 22:19 ` [PATCH v2 1/2] sunrpc: treat empty auth.unix.gid replies as negative entries Ameer Hamza
2026-08-14 22:19 ` [PATCH v2 2/2] sunrpc: honor the netlink unix_gid NEGATIVE flag Ameer Hamza
2026-08-15 10:50 ` [PATCH v2 0/2] sunrpc: don't strip a uid's groups when the mountd group lookup fails Jeff Layton
2026-08-15 12:31   ` Ameer Hamza
2026-08-15 16:24 ` Chuck Lever [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=178681105303.93379.12774054259768112149.b4-ty@b4 \
    --to=cel@kernel.org \
    --cc=Dai.Ngo@oracle.com \
    --cc=alexander.motin@truenas.com \
    --cc=ameer.hamza@truenas.com \
    --cc=caleb.stjohn@truenas.com \
    --cc=jlayton@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=neil@brown.name \
    --cc=okorniev@redhat.com \
    --cc=tom@talpey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®