mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Rob Herring (Arm)" <robh@kernel.org>
To: Bhargav Joshi <j.bhargav.u@gmail.com>
Cc: daniel.baluta@gmail.com, Lee Jones <lee@kernel.org>,
	 linux-kernel@vger.kernel.org,
	Ivan Khoronzhuk <ivan.khoronzhuk@ti.com>,
	 Krzysztof Kozlowski <krzk+dt@kernel.org>,
	 Conor Dooley <conor+dt@kernel.org>,
	mfd@lists.linux.dev,  linux-arm-kernel@lists.infradead.org,
	goledhruva@gmail.com,  Nishanth Menon <nm@ti.com>,
	Santosh Shilimkar <ssantosh@kernel.org>,
	 simona.toaca@nxp.com, devicetree@vger.kernel.org,
	m-chawdhry@ti.com
Subject: Re: [PATCH v2 2/2] dt-bindings: mfd: ti,keystone-devctrl: Convert to DT schema
Date: Mon, 17 Aug 2026 08:22:26 -0500	[thread overview]
Message-ID: <178697294672.115607.1502530861180483583.robh@kernel.org> (raw)
In-Reply-To: <20260816-ti-keystone-devctrl-v2-2-5ab1e13c15c1@gmail.com>


On Sun, 16 Aug 2026 00:23:00 +0530, Bhargav Joshi wrote:
> Convert the Texas Instruments Keystone Device State Control binding from
> legacy text format to DT schema.
> 
> During the conversion, the following updates were made:
> - Add "simple-mfd" to compatibles matching existing dts usage.
> - Add required bus properties #address-cells, #size-cells, and ranges
>   which were missing in text binding.
> - Document child nodes gpio, interrupt-controller, and reset-controller.
> 
> Signed-off-by: Bhargav Joshi <j.bhargav.u@gmail.com>
> ---
> Note: Running dt_binding_check on patch will yield a warning for
> 'ti,keystone-reset' in the example block. The YAML conversion patch for
> that child node is already in progress here:
> https://lore.kernel.org/linux-devicetree/20260813-ti-keystone-reset-v1-1-189389503324@gmail.com/
> ---
>  .../bindings/mfd/ti,keystone-devctrl.yaml          | 84 ++++++++++++++++++++++
>  .../bindings/mfd/ti-keystone-devctrl.txt           | 19 -----
>  2 files changed, 84 insertions(+), 19 deletions(-)
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
Documentation/devicetree/bindings/mfd/ti,keystone-devctrl.example.dtb: /example-0/device-state-control@2620000/reset-controller@328: failed to match any schema with compatible: ['ti,keystone-reset']
Documentation/devicetree/bindings/mfd/ti,keystone-devctrl.example.dtb: reset-controller@328 (ti,keystone-reset): ti,syscon-pll: b'\xff\xff\xff\xff\x00\x00\x00\xe4' is not of type 'object', 'integer', 'array', 'boolean', 'null'
	from schema $id: http://devicetree.org/schemas/dt-core.yaml
Documentation/devicetree/bindings/mfd/ti,keystone-devctrl.example.dtb: reset-controller@328 (ti,keystone-reset): ti,wdt-list: b'\x00\x00\x00\x00' is not of type 'object', 'integer', 'array', 'boolean', 'null'
	from schema $id: http://devicetree.org/schemas/dt-core.yaml

doc reference errors (make refcheckdocs):

See https://patchwork.kernel.org/project/devicetree/patch/20260816-ti-keystone-devctrl-v2-2-5ab1e13c15c1@gmail.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.


  reply	other threads:[~2026-08-17 13:22 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-15 18:52 [PATCH v2 0/2] ti,keystone-devctrl: Convert to DT schema and DTS cleanups Bhargav Joshi
2026-08-15 18:52 ` [PATCH v2 1/2] ARM: dts: ti: keystone: Align devctrl child node names with dtschema Bhargav Joshi
2026-08-15 18:53 ` [PATCH v2 2/2] dt-bindings: mfd: ti,keystone-devctrl: Convert to DT schema Bhargav Joshi
2026-08-17 13:22   ` Rob Herring (Arm) [this message]
2026-08-18  7:01   ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=178697294672.115607.1502530861180483583.robh@kernel.org \
    --to=robh@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=daniel.baluta@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=goledhruva@gmail.com \
    --cc=ivan.khoronzhuk@ti.com \
    --cc=j.bhargav.u@gmail.com \
    --cc=krzk+dt@kernel.org \
    --cc=lee@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=m-chawdhry@ti.com \
    --cc=mfd@lists.linux.dev \
    --cc=nm@ti.com \
    --cc=simona.toaca@nxp.com \
    --cc=ssantosh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®