From: Stephen Boyd <sboyd@kernel.org>
To: Pedro Kopper <pedro.kopper@microchip.com>, linux-kernel@vger.kernel.org
Cc: linux-riscv@lists.infradead.org, linux-clk@vger.kernel.org,
daire.mcnamara@microchip.com, mturquette@baylibre.com,
bmasney@redhat.com, valentina.fernandezalanis@microchip.com,
conor.dooley@microchip.com, pedro.kopper@microchip.com
Subject: Re: [PATCH] clk: microchip: mpfs: fix regmap_update_bits() mask/val order
Date: Wed, 19 Aug 2026 23:12:02 -0700 [thread overview]
Message-ID: <178720632220.4726.4647859230125526989@lazor> (raw)
In-Reply-To: <20260814092211.2158337-3-pedro.kopper@microchip.com>
Quoting Pedro Kopper (2026-08-14 02:22:13)
> mpfs_cfg_clk_set_rate() passes the mask and value arguments to
> regmap_update_bits() in the wrong order. The resulting write becomes
> reg = orig_reg | val, causing bits to not be cleared if the clock
> divider changes.
>
> Pass the arguments in the correct order so the divider field is updated
> as intended.
>
> Fixes: c6f2dddfa7f9 ("clk: microchip: mpfs: use regmap for clocks")
> Signed-off-by: Pedro Kopper <pedro.kopper@microchip.com>
> ---
Applied to clk-next
prev parent reply other threads:[~2026-08-20 6:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-14 9:22 Pedro Kopper
2026-08-14 15:22 ` Conor Dooley
2026-08-20 6:12 ` Stephen Boyd [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=178720632220.4726.4647859230125526989@lazor \
--to=sboyd@kernel.org \
--cc=bmasney@redhat.com \
--cc=conor.dooley@microchip.com \
--cc=daire.mcnamara@microchip.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=mturquette@baylibre.com \
--cc=pedro.kopper@microchip.com \
--cc=valentina.fernandezalanis@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®