mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Kees Cook <kees@kernel.org>
To: Christian Brauner <brauner@kernel.org>, Oleg Nesterov <oleg@redhat.com>
Cc: Kees Cook <kees@kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>,
	Kusaram Devineni <kusaram@devineni.in>,
	Jens Axboe <axboe@kernel.dk>,
	linux-kernel@vger.kernel.org, io-uring@vger.kernel.org
Subject: Re: [PATCH v2] signalfd: don't dequeue the forced fatal signals
Date: Wed,  2 Sep 2026 20:39:29 -0700	[thread overview]
Message-ID: <178840676820.2647250.10962752052192481814.b4-ty@kernel.org> (raw)
In-Reply-To: <adO3HG8bvwRPcmte@redhat.com>

On Mon, 06 Apr 2026 15:37:32 +0200, Oleg Nesterov wrote:
> These signals should act like SIGKILL, in that userspace must never dequeue
> them. But as Kusaram explains, io_uring-driven signalfd_read_iter() called
> from get_signal() -> task_work_run() paths can do this before get_signal()
> has a chance to dequeue such a signal and notice SA_IMMUTABLE.
> 
> Change signalfd_poll() and signalfd_dequeue() to add pending SA_IMMUTABLE
> signals to ctx->sigmask.
> 
> [...]

Applied to for-next/hardening, thanks!

[1/1] signalfd: don't dequeue the forced fatal signals
      https://git.kernel.org/kees/c/37eadcb919b0

Take care,

-- 
Kees Cook


  parent reply	other threads:[~2026-09-03  3:39 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-04-05 16:09 [PATCH] " Oleg Nesterov
2026-04-06  4:39 ` Kees Cook
2026-04-06 13:32   ` Oleg Nesterov
2026-04-06 13:37   ` [PATCH v2] " Oleg Nesterov
2026-06-19 14:03     ` Oleg Nesterov
2026-06-19 20:47       ` Kees Cook
2026-09-03  3:39     ` Kees Cook [this message]
2026-04-07 20:10 ` [PATCH] " kernel test robot
2026-04-07 21:22   ` Oleg Nesterov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=178840676820.2647250.10962752052192481814.b4-ty@kernel.org \
    --to=kees@kernel.org \
    --cc=akpm@linux-foundation.org \
    --cc=axboe@kernel.dk \
    --cc=brauner@kernel.org \
    --cc=io-uring@vger.kernel.org \
    --cc=kusaram@devineni.in \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oleg@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®