From: Vinod Koul <vkoul@kernel.org>
To: dmaengine@vger.kernel.org, Rosen Penev <rosenp@gmail.com>
Cc: Frank Li <Frank.Li@kernel.org>,
Harninder Rai <harninder.rai@freescale.com>,
Xuelin Shi <xuelin.shi@freescale.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] dmaengine: fsl_raid: don't invoke client callback under desc_lock
Date: Thu, 03 Sep 2026 22:34:23 +0530 [thread overview]
Message-ID: <178845506309.1711546.13763967844499804503.b4-ty@kernel.org> (raw)
In-Reply-To: <20260718053010.3074329-1-rosenp@gmail.com>
On Fri, 17 Jul 2026 22:30:10 -0700, Rosen Penev wrote:
> fsl_re_dequeue() holds re_chan->desc_lock while calling
> fsl_re_desc_done(), which synchronously invokes the DMA client completion
> callback via dmaengine_desc_get_callback_invoke(). If that callback
> submits new work (e.g. fsl_re_tx_submit()), it tries to reacquire the
> same desc_lock and deadlocks on the spinlock.
>
> Collect completed descriptors into a local list under the lock, then
> release the lock and invoke the callbacks before moving the descriptors
> to the ack queue.
>
> [...]
Applied, thanks!
[1/1] dmaengine: fsl_raid: don't invoke client callback under desc_lock
commit: 62c267ce97444f8a381f2bb3cd5d534eb362c540
Best regards,
--
~Vinod
prev parent reply other threads:[~2026-09-03 17:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-18 5:30 Rosen Penev
2026-07-18 14:15 ` Frank Li
2026-09-03 17:04 ` Vinod Koul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=178845506309.1711546.13763967844499804503.b4-ty@kernel.org \
--to=vkoul@kernel.org \
--cc=Frank.Li@kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=harninder.rai@freescale.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rosenp@gmail.com \
--cc=xuelin.shi@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®