From: Bjorn Andersson <andersson@kernel.org>
To: Konrad Dybcio <konradybcio@kernel.org>,
linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org,
Ben Dooks <ben.dooks@codethink.co.uk>
Subject: Re: [PATCH] soc: qcom: smp2p: fix __iomem annotation on entry->value pointer
Date: Thu, 3 Sep 2026 12:20:32 -0500 [thread overview]
Message-ID: <178845603567.348193.5253103235451005367.b4-ty@kernel.org> (raw)
In-Reply-To: <20260623085931.589735-1-ben.dooks@codethink.co.uk>
On Tue, 23 Jun 2026 09:59:31 +0100, Ben Dooks wrote:
> The entry->value is passed to readl() so should be marked __iomem
> so remove these sparse warnings by marking it __iomem and do the
> relevant casting to ensure no further warnings:
>
> drivers/soc/qcom/smp2p.c:280:64: warning: incorrect type in argument 1 (different address spaces)
> drivers/soc/qcom/smp2p.c:280:64: expected void const volatile [noderef] __iomem *addr
> drivers/soc/qcom/smp2p.c:280:64: got unsigned int [usertype] *value
> drivers/soc/qcom/smp2p.c:318:34: warning: incorrect type in argument 1 (different address spaces)
> drivers/soc/qcom/smp2p.c:318:34: expected void const volatile [noderef] __iomem *addr
> drivers/soc/qcom/smp2p.c:318:34: got unsigned int [usertype] *value
> drivers/soc/qcom/smp2p.c:446:26: warning: incorrect type in argument 1 (different address spaces)
> drivers/soc/qcom/smp2p.c:446:26: expected void const volatile [noderef] __iomem *addr
> drivers/soc/qcom/smp2p.c:446:26: got unsigned int [usertype] *value
> drivers/soc/qcom/smp2p.c:501:33: warning: incorrect type in argument 1 (different address spaces)
> drivers/soc/qcom/smp2p.c:501:33: expected void const volatile [noderef] __iomem *addr
> drivers/soc/qcom/smp2p.c:501:33: got unsigned int [usertype] *value
> drivers/soc/qcom/smp2p.c:504:26: warning: incorrect type in argument 2 (different address spaces)
> drivers/soc/qcom/smp2p.c:504:26: expected void volatile [noderef] __iomem *addr
> drivers/soc/qcom/smp2p.c:504:26: got unsigned int [usertype] *value
>
> [...]
Applied, thanks!
[1/1] soc: qcom: smp2p: fix __iomem annotation on entry->value pointer
commit: c5b0ca559afa50ce4ab39e85da927261814373e2
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
prev parent reply other threads:[~2026-09-03 17:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-23 8:59 Ben Dooks
2026-06-23 9:30 ` Konrad Dybcio
2026-07-07 3:29 ` Bjorn Andersson
2026-09-03 17:20 ` Bjorn Andersson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=178845603567.348193.5253103235451005367.b4-ty@kernel.org \
--to=andersson@kernel.org \
--cc=ben.dooks@codethink.co.uk \
--cc=konradybcio@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®