Re: [net-next,v12,4/7] r8169: enable new interrupt mapping

[netdev-bot+sashiko@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue(s) to consider:

Critical: 0 · High: 0 · Medium: 0 · Low: 1

- [Low] Commit message claims "This patch enables new interrupt mapping
  for RTL8127", but at this commit the new hardware write in…

--

r8169: enable new interrupt mapping

This patch sets the new interrupt vector mapping bit (INT_CFG0_ENABLE_8125)
in rtl_hw_start_8125_common() when more than one IRQ vector is in use.  It
also moves the rx errors/dropped/length/crc/multicast counters out of
dev->stats into per-ring counters protected by u64_stats_sync, summed in
rtl8169_get_stats64().

No Link: tags are present in the commit header.

I looked over the per-ring statistics conversion and the new vector mapping
enable path and did not find regressions to raise.  One item I initially
flagged turned out not to be a problem, noted inline below for the record.

> diff --git a/drivers/net/ethernet/realtek/r8169_main.c b/drivers/net/ethernet/realtek/r8169_main.c
> index ca6be1e38408..1798a98b860b 100644
> --- a/drivers/net/ethernet/realtek/r8169_main.c
> +++ b/drivers/net/ethernet/realtek/r8169_main.c

[ ... ]

> @@ -3947,6 +3966,9 @@ static void rtl_hw_start_8125_common(struct rtl8169_private *tp)
>  	RTL_W32(tp, RSS_CTRL_8125, 0);
>  	RTL_W16(tp, Q_NUM_CTRL_8125, 0);
>  
> +	if (tp->irq_nvecs > 1)
> +		rtl8169_hw_enable_vec_mapping(tp);
> +

At this commit rtl_alloc_irq() still calls pci_alloc_irq_vectors() with both
the minimum and maximum vector count set to 1, so tp->irq_nvecs is always 1
and this call never runs yet.

The later commit in this series ("r8169: add support and enable rss")
switches rtl_alloc_irq() to get_min_irq_nvecs()/get_max_irq_nvecs() and
raises tp->num_rx_rings via rtl8169_set_rx_ring_num(), so this is just the
usual infrastructure-first ordering within a series and not a defect.

>  	/* disable UPS */
>  	r8168_mac_ocp_modify(tp, 0xd40a, 0x0010, 0x0000);
>  

[ ... ]

-- 
Sashiko AI review · https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20260831053940.620-1-javen_xu%40realsil.com.cn