From: John Crispin <john@phrozen.org>
To: "André Draszik" <git@andred.net>, linux-kernel@vger.kernel.org
Cc: linux-mips@linux-mips.org, Ralf Baechle <ralf@linux-mips.org>
Subject: Re: [PATCH] MIPS: ralink: fix mt7628 alternative functions names
Date: Fri, 10 Feb 2017 10:12:24 +0100 [thread overview]
Message-ID: <17885154-71f7-2d1e-7046-757e092de508@phrozen.org> (raw)
In-Reply-To: <20170210090659.21873-1-git@andred.net>
On 10/02/2017 10:06, André Draszik wrote:
> They're all referenced as utif in the datasheet, not util.
>
> Fixes: 53263a1c6852 ("MIPS: ralink: add mt7628an support")
> Fixes: 2b436a351803 ("MIPS: ralink: add MT7628 EPHY LEDs pinmux support")
>
> Signed-off-by: André Draszik <git@andred.net>
I was under the impression that I had sent this patch already, maybe it
got lost somewhere along the line
Acked-by: John Crispin <john@phrozen.org>
> ---
> arch/mips/ralink/mt7620.c | 18 +++++++++---------
> 1 file changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/arch/mips/ralink/mt7620.c b/arch/mips/ralink/mt7620.c
> index 3c7c9bf57bf3..6f892c1f3ad7 100644
> --- a/arch/mips/ralink/mt7620.c
> +++ b/arch/mips/ralink/mt7620.c
> @@ -176,7 +176,7 @@ static struct rt2880_pmx_func spi_cs1_grp_mt7628[] = {
>
> static struct rt2880_pmx_func spis_grp_mt7628[] = {
> FUNC("pwm_uart2", 3, 14, 4),
> - FUNC("util", 2, 14, 4),
> + FUNC("utif", 2, 14, 4),
> FUNC("gpio", 1, 14, 4),
> FUNC("spis", 0, 14, 4),
> };
> @@ -190,28 +190,28 @@ static struct rt2880_pmx_func gpio_grp_mt7628[] = {
>
> static struct rt2880_pmx_func p4led_kn_grp_mt7628[] = {
> FUNC("jtag", 3, 30, 1),
> - FUNC("util", 2, 30, 1),
> + FUNC("utif", 2, 30, 1),
> FUNC("gpio", 1, 30, 1),
> FUNC("p4led_kn", 0, 30, 1),
> };
>
> static struct rt2880_pmx_func p3led_kn_grp_mt7628[] = {
> FUNC("jtag", 3, 31, 1),
> - FUNC("util", 2, 31, 1),
> + FUNC("utif", 2, 31, 1),
> FUNC("gpio", 1, 31, 1),
> FUNC("p3led_kn", 0, 31, 1),
> };
>
> static struct rt2880_pmx_func p2led_kn_grp_mt7628[] = {
> FUNC("jtag", 3, 32, 1),
> - FUNC("util", 2, 32, 1),
> + FUNC("utif", 2, 32, 1),
> FUNC("gpio", 1, 32, 1),
> FUNC("p2led_kn", 0, 32, 1),
> };
>
> static struct rt2880_pmx_func p1led_kn_grp_mt7628[] = {
> FUNC("jtag", 3, 33, 1),
> - FUNC("util", 2, 33, 1),
> + FUNC("utif", 2, 33, 1),
> FUNC("gpio", 1, 33, 1),
> FUNC("p1led_kn", 0, 33, 1),
> };
> @@ -232,28 +232,28 @@ static struct rt2880_pmx_func wled_kn_grp_mt7628[] = {
>
> static struct rt2880_pmx_func p4led_an_grp_mt7628[] = {
> FUNC("jtag", 3, 39, 1),
> - FUNC("util", 2, 39, 1),
> + FUNC("utif", 2, 39, 1),
> FUNC("gpio", 1, 39, 1),
> FUNC("p4led_an", 0, 39, 1),
> };
>
> static struct rt2880_pmx_func p3led_an_grp_mt7628[] = {
> FUNC("jtag", 3, 40, 1),
> - FUNC("util", 2, 40, 1),
> + FUNC("utif", 2, 40, 1),
> FUNC("gpio", 1, 40, 1),
> FUNC("p3led_an", 0, 40, 1),
> };
>
> static struct rt2880_pmx_func p2led_an_grp_mt7628[] = {
> FUNC("jtag", 3, 41, 1),
> - FUNC("util", 2, 41, 1),
> + FUNC("utif", 2, 41, 1),
> FUNC("gpio", 1, 41, 1),
> FUNC("p2led_an", 0, 41, 1),
> };
>
> static struct rt2880_pmx_func p1led_an_grp_mt7628[] = {
> FUNC("jtag", 3, 42, 1),
> - FUNC("util", 2, 42, 1),
> + FUNC("utif", 2, 42, 1),
> FUNC("gpio", 1, 42, 1),
> FUNC("p1led_an", 0, 42, 1),
> };
>
next prev parent reply other threads:[~2017-02-10 9:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-10 9:06 André Draszik
2017-02-10 9:12 ` John Crispin [this message]
2017-02-10 17:06 ` James Hogan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17885154-71f7-2d1e-7046-757e092de508@phrozen.org \
--to=john@phrozen.org \
--cc=git@andred.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®