From: patchwork-bot+bluetooth@kernel.org
To: Xuhua Zhang <zhangxuhua@kylinsec.com.cn>
Cc: marcel@holtmann.org, luiz.dentz@gmail.com,
linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Bluetooth: hci_h5: Avoid clearing the escape bit for ordinary bytes
Date: Tue, 08 Sep 2026 16:30:35 +0000 [thread overview]
Message-ID: <178888503563.3627954.6813577109173768938.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <8B4A9BA701BE6DED+20260907150808.13442-1-zhangxuhua@kylinsec.com.cn>
Hello:
This patch was applied to bluetooth/bluetooth-next.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:
On Mon, 7 Sep 2026 23:08:08 +0800 you wrote:
> h5_unslip_one_byte() calls test_and_clear_bit() for every byte other than
> an initial SLIP escape byte, even when H5_RX_ESC is already clear. This
> performs an unnecessary atomic read-modify-write on the ordinary-byte
> receive path. On x86, it emits a locked btr instruction for each such
> byte.
>
> Test H5_RX_ESC first and clear it only when consuming an escaped byte.
> Handle an initial SLIP escape byte in the alternative branch. The HCI
> UART receive callbacks are serialized by the TTY layer, and H5_RX_ESC
> is only changed by receive processing and initialization, so there is
> no need to atomically test and clear it in one operation.
>
> [...]
Here is the summary with links:
- Bluetooth: hci_h5: Avoid clearing the escape bit for ordinary bytes
https://git.kernel.org/bluetooth/bluetooth-next/c/676cc47454c4
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2026-09-08 16:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-07 15:08 Xuhua Zhang
2026-09-08 16:30 ` patchwork-bot+bluetooth [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=178888503563.3627954.6813577109173768938.git-patchwork-notify@kernel.org \
--to=patchwork-bot+bluetooth@kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
--cc=marcel@holtmann.org \
--cc=zhangxuhua@kylinsec.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®