From: patchwork-bot+netdevbpf@kernel.org
To: Aleksei Sviridkin <f@lex.la>
Cc: andrew@lunn.ch, hkallweit1@gmail.com, linux@armlinux.org.uk,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, vladimir.oltean@nxp.com,
rmk+kernel@armlinux.org.uk, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] net: phylink: initialise link_state before a forced major config
Date: Thu, 10 Sep 2026 01:50:05 +0000 [thread overview]
Message-ID: <178900500538.1147948.10957190868823159726.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <20260904185540.2844261-1-f@lex.la>
Hello:
This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@kernel.org>:
On Fri, 4 Sep 2026 18:55:40 +0000 you wrote:
> phylink_resolve() leaves link_state on the stack unpopulated on its
> disable and link-failed branches, which set only link_state.link.
> phylink_apply_manual_flow() then reads the struct's advertising on
> every mode but MLO_AN_FIXED, and has done so since long before
> force_major_config existed.
>
> force_major_config turns that into a write to the hardware. It is the
> only trigger for the major-config block that does not require
> mac_config, so phylink_major_config() programs the MAC for whatever
> the stack held, a zeroed interface is PHY_INTERFACE_MODE_NA, and the
> write-back stores it in pl->link_config.interface.
>
> [...]
Here is the summary with links:
- [net] net: phylink: initialise link_state before a forced major config
https://git.kernel.org/netdev/net/c/113998aa372f
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2026-09-10 1:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-04 18:55 Aleksei Sviridkin
2026-09-10 1:50 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=178900500538.1147948.10957190868823159726.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=f@lex.la \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rmk+kernel@armlinux.org.uk \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®