mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Rob Herring (Arm)" <robh@kernel.org>
To: Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>
Cc: Conor Dooley <conor+dt@kernel.org>, Takashi Iwai <tiwai@suse.com>,
	 Bard Liao <yung-chuan.liao@linux.intel.com>,
	 Pierre-Louis Bossart <pierre-louis.bossart@linux.dev>,
	 Mark Brown <broonie@kernel.org>,
	Jaroslav Kysela <perex@perex.cz>,
	 linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
	 Charles Keepax <ckeepax@opensource.cirrus.com>,
	 patches@opensource.cirrus.com,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	 Liam Girdwood <lgirdwood@gmail.com>,
	linux-kernel@vger.kernel.org,
	 Maciej Strozek <mstrozek@opensource.cirrus.com>,
	 linux-sound@vger.kernel.org
Subject: Re: [PATCH v3 7/8] dt-bindings: sound: qcom: add Tambora WCD9378 SDCA codec
Date: Tue, 15 Sep 2026 16:57:54 -0500	[thread overview]
Message-ID: <178950938407.3847226.1050939911266528360.robh@kernel.org> (raw)
In-Reply-To: <20260915165652.914893-8-srinivas.kandagatla@oss.qualcomm.com>


On Tue, 15 Sep 2026 17:56:49 +0100, Srinivas Kandagatla wrote:
> Describe the WCD9378 SoundWire peripheral which is SDCA compatible
> soundwire device. It provides SDCA SimpleJack for headphone playback
> headset mic capture and MBHC jack detection.
> 
> The same silicon is integrated in two ways and enumerates with the
> same SoundWire class ID:
> 
>   mobile mode: two slaves (tx, rx) on separate SoundWire masters.
> 
>   SDCA / compute mode: one aggregated slave on a multi-lane
>   master.
> 
> Note: both of them have different bus toplogies 1 device vs 2 devices.
> 
> Currently only compute mode is supported by this bindings, mobile mode
> will extend this binding as required.
> 
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@oss.qualcomm.com>
> ---
>  .../bindings/sound/qcom,wcd9378-sdw.yaml      | 91 +++++++++++++++++++
>  1 file changed, 91 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/sound/qcom,wcd9378-sdw.yaml
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
Documentation/devicetree/bindings/sound/qcom,wcd9378-sdw.example.dtb: soundwire@7630000: audio-codec@0,3:compatible:0: 'qcom,wcd9378c' does not match '^sdw[0-9a-f]{1}[0-9a-f]{4}[0-9a-f]{4}[0-9a-f]{2}$'
	from schema $id: http://devicetree.org/schemas/soundwire/soundwire-controller.yaml
Documentation/devicetree/bindings/sound/qcom,wcd9378-sdw.example.dtb: soundwire@7630000: audio-codec@0,3:compatible: ['qcom,wcd9378c', 'sdw20217011000'] is too long
	from schema $id: http://devicetree.org/schemas/soundwire/soundwire-controller.yaml

doc reference errors (make refcheckdocs):

See https://patchwork.kernel.org/project/devicetree/patch/20260915165652.914893-8-srinivas.kandagatla@oss.qualcomm.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.


  reply	other threads:[~2026-09-15 21:57 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-15 16:56 [PATCH v3 0/8] ASoC: SDCA: Qualcomm Tambora (WCD9378) SDCA codec support Srinivas Kandagatla
2026-09-15 16:56 ` [PATCH v3 1/8] ASoC: SDCA: allow building without ACPI Srinivas Kandagatla
2026-09-15 16:56 ` [PATCH v3 2/8] ASoC: SDCA: export PM helpers keyed on sdca_class_drv Srinivas Kandagatla
2026-09-15 16:56 ` [PATCH v3 3/8] ASoC: SDCA: expose class SoundWire probe/remove as library Srinivas Kandagatla
2026-09-15 16:56 ` [PATCH v3 4/8] ASoC: SDCA: add class_ops with populate_function Srinivas Kandagatla
2026-09-15 16:56 ` [PATCH v3 5/8] ASoC: SDCA: class_function: xlate sound-dai cell by entity index Srinivas Kandagatla
2026-09-15 16:56 ` [PATCH v3 6/8] ASoC: SDCA: add sdca_apply_default_control_classifiers() helper Srinivas Kandagatla
2026-09-15 16:56 ` [PATCH v3 7/8] dt-bindings: sound: qcom: add Tambora WCD9378 SDCA codec Srinivas Kandagatla
2026-09-15 21:57   ` Rob Herring (Arm) [this message]
2026-09-16  6:53   ` Krzysztof Kozlowski
2026-09-16 16:30     ` Srinivas Kandagatla
2026-09-15 16:56 ` [PATCH v3 8/8] ASoC: codecs: add Qualcomm Tambora (WCD9378) " Srinivas Kandagatla
2026-09-15 17:22   ` Uwe Kleine-König
2026-09-15 22:30     ` Srinivas Kandagatla
2026-09-15 18:46   ` Mark Brown
2026-09-15 20:55     ` Srinivas Kandagatla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=178950938407.3847226.1050939911266528360.robh@kernel.org \
    --to=robh@kernel.org \
    --cc=broonie@kernel.org \
    --cc=ckeepax@opensource.cirrus.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=mstrozek@opensource.cirrus.com \
    --cc=patches@opensource.cirrus.com \
    --cc=perex@perex.cz \
    --cc=pierre-louis.bossart@linux.dev \
    --cc=srinivas.kandagatla@oss.qualcomm.com \
    --cc=tiwai@suse.com \
    --cc=yung-chuan.liao@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®