From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 001FA768EA; Thu, 17 Sep 2026 18:38:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789670291; cv=none; b=irud2IQMqopHk3GMZxJS2iYCHQ2EC0ntondj9xKUkJEDF6vVGymH7zuf7fq02lwXGDML/yHRbDx5UKhuy4XtKtVhB3+KYOy4Qy1h28jflYTsgnY2mjMT75bJvBcEoA5TEYzQn/Wh119L/KgShnuKRtvspmnywoevqpt75Oms9qc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789670291; c=relaxed/simple; bh=LhisimdP2/Bc31zOWA21C7kd3rvG4zXAFY4VpRjSJL8=; h=Subject:From:To:Cc:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=FX5pNnEvQXPsoROpEtl9H3U5yHE1VOw1c2X/4sHvPUfK7By6gD6RGqbBjyiDW0uUFqMyyli79irz+0EZ1qMk8rfAfw4VhbyiXfzFCwQv7D3BAvZbKv9QlrhkrSj0GddjnsJF8fz7j0PkVUeEHiLy2WLNzmexlnZVnccMMfNyRoM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Z8ljo9ih; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Z8ljo9ih" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E79FA1F00893; Thu, 17 Sep 2026 18:38:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1789670289; bh=yxebnu98m4tIYnDFX7Ssph7AnvZbMmHlUSJWYuXN+jw=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=Z8ljo9ih31/foT9aRUgqlAoM2YjYSBOuxI8gBJwP/Kq9cRZlpzVPz+gD8By6pVDH+ phpLR//Njg7RPEsmD6K2vQ6twMkCjY/oM0yYOSr/uUBICYrgdWueJqYnSv62M/xEKf 2j8nOmAdcmOqfSmltzjZr2nGOfjCSGAD5s0Nd32+qIqMJC04ZeFa5IrdmPISufInEQ edztpctqu8vcDcmAothpwmvpXhGM9hWOvP7mqNSEegRXyWsdE7vefFFyj8IWg0uNeA Zdlsm87M79WfTxgPovHPiL7XOfCOvfGKBGBNjavhQWeF9ijBNG7YO55T9EcSKl64y7 hkd/CpZs4UEDw== Subject: Re: [PATCH net-next v6 02/11] dt-bindings: phy: rockchip: naneng-combphy: add rockchip,sgmii-mac-sel property From: netdev-bot+sashiko@kernel.org To: coiaprant@gmail.com Cc: andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, heiko@sntech.de, vkoul@kernel.org, maxime.chevallier@bootlin.com, mcoquelin.stm32@gmail.com, alexandre.torgue@foss.st.com, prabhakar.mahadev-lad.rj@bp.renesas.com, romain.gantois@bootlin.com, hkallweit1@gmail.com, neil.armstrong@linaro.org, linux@armlinux.org.uk, shawn.lin@rock-chips.com, david@ixit.cz, netdev@vger.kernel.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, linux-renesas-soc@vger.kernel.org Date: Thu, 17 Sep 2026 18:38:07 +0000 Message-ID: <178967028750.22033.16679846848252928482@kernel.org> In-Reply-To: <20260915123802.1561724-3-coiaprant@gmail.com> References: <20260915123802.1561724-3-coiaprant@gmail.com> X-sashiko-severity: Low Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider: Critical: 0 · High: 0 · Medium: 0 · Low: 1 - [Low] Concern (verified FALSE POSITIVE, retained only per validation policy): the binding was said to document `rockchip,sgmii-mac-sel`… -- dt-bindings: phy: rockchip: naneng-combphy: add rockchip,sgmii-mac-sel property This adds an optional uint32 property rockchip,sgmii-mac-sel to the naneng-combphy binding, gated so it is only accepted for rockchip,rk3568-naneng-combphy. The value selects whether SGMII is routed to GMAC0 (0) or GMAC1 (1), with 1 documented as the hardware reset value. > diff --git a/Documentation/devicetree/bindings/phy/phy-rockchip-naneng-combphy.yaml b/Documentation/devicetree/bindings/phy/phy-rockchip-naneng-combphy.yaml > index 379b08bd9e97a..8e898bce9af73 100644 > --- a/Documentation/devicetree/bindings/phy/phy-rockchip-naneng-combphy.yaml > +++ b/Documentation/devicetree/bindings/phy/phy-rockchip-naneng-combphy.yaml > @@ -80,6 +80,15 @@ properties: > description: > Some additional pipe settings are accessed through GRF regs. > > + rockchip,sgmii-mac-sel: > + $ref: /schemas/types.yaml#/definitions/uint32 > + enum: [0, 1] > + default: 1 > + description: > + Select gmac0 or gmac1 to be used as SGMII controller. > + The hardware reset value is GMAC1 (1). Set this to 0 to route > + SGMII to GMAC0. > + [Severity: Low] This isn't a bug, just a note on patch ordering for anyone reading this patch on its own: at this commit there is no in-tree consumer of rockchip,sgmii-mac-sel yet, so the new ABI looks inert here. Checking the rest of the series, the consumer does arrive immediately after in "phy: rockchip: naneng-combphy: add SGMII MAC selection for RK3568", which parses the property in rockchip_combphy_parse_dt(): priv->sgmii_mac_sel = 1; device_property_read_u32(dev, "rockchip,sgmii-mac-sel", &priv->sgmii_mac_sel); and applies it in the PHY_TYPE_SGMII branch of rk3568_combphy_cfg(): rockchip_combphy_param_write(priv->pipe_grf, &cfg->pipe_sgmii_mac_sel, priv->sgmii_mac_sel > 0); with the RK3568 descriptor .pipe_sgmii_mac_sel = { 0x0040, 1, 1, 0x00, 0x01 }, and the Photonicat DT patch then sets rockchip,sgmii-mac-sel = <0> on &combphy2. So the GMAC0 routing does work at the end of the series and there is nothing to fix; would it be worth mentioning the driver patch in this commit message so the dependency is obvious when the binding is reviewed in isolation? > [ ... ] -- Sashiko AI review · https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20260915123802.1561724-1-coiaprant%40gmail.com