Re: [PATCH v28 net-next 01/10] net/nebula-matrix: add minimum nbl build framework

[netdev-bot+sashiko@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue(s) to consider:

Critical: 0 · High: 0 · Medium: 0 · Low: 1

- [Low] At this commit only, the user-facing artifacts describe
  functionality that the added code does not contain: CONFIG_NBL help…

--

net/nebula-matrix: add minimum nbl build framework

This adds the Kconfig, Makefile, MAINTAINERS entry and documentation for a
new nebula-matrix ethernet driver, plus a PCI driver skeleton whose probe
and remove callbacks are empty stubs.  The commit message notes that the
real implementation follows in later patches of the series.

> diff --git a/Documentation/networking/device_drivers/ethernet/nebula-matrix/nbl.rst b/Documentation/networking/device_drivers/ethernet/nebula-matrix/nbl.rst
> new file mode 100644
> index 0000000000000..5540291cf3766
> --- /dev/null
> +++ b/Documentation/networking/device_drivers/ethernet/nebula-matrix/nbl.rst
> @@ -0,0 +1,28 @@

[ ... ]

> +This driver provides the core infrastructure for m18110/m18000-NIC
> +devices, including:
> +
> +- PCI device enumeration and resource (BAR) management
> +- Firmware command interface via PF mailbox
> +- Channel-based communication between driver and firmware
> +- Device initialization and teardown

[ ... ]

> diff --git a/drivers/net/ethernet/nebula-matrix/Kconfig b/drivers/net/ethernet/nebula-matrix/Kconfig
> new file mode 100644
> index 0000000000000..dd0e91d14131f
> --- /dev/null
> +++ b/drivers/net/ethernet/nebula-matrix/Kconfig
> @@ -0,0 +1,32 @@

[ ... ]

> +config NBL
> +	tristate "Nebula-matrix Ethernet Controller m18110/m18000 support"
> +	depends on PCI && (64BIT || COMPILE_TEST) && !CPU_BIG_ENDIAN
> +	help
> +	  This driver provides the core infrastructure for Nebula-matrix
> +	  Ethernet Controller m18110/m18000 Family of devices, including
> +	  PCI enumeration, firmware mailbox and channel communication.

[Severity: Low]
This isn't a bug, but the commit message says:

  Note: the documentation describes the final full driver features;
  implementation will be added in subsequent patches of this series.

That disclaimer covers nbl.rst, but the CONFIG_NBL help text makes the same
claims ("PCI enumeration, firmware mailbox and channel communication") and
isn't mentioned.  At this commit nbl_probe() just returns -ENODEV and
nbl_remove() is empty, so none of the described infrastructure exists yet.

Would it make sense to either extend the note to cover the Kconfig help
text, or move the feature list into the patch that actually adds the
enumeration, mailbox and channel code?

[ ... ]

> diff --git a/drivers/net/ethernet/nebula-matrix/nbl/nbl_main.c b/drivers/net/ethernet/nebula-matrix/nbl/nbl_main.c
> new file mode 100644
> index 0000000000000..199626159a4ce
> --- /dev/null
> +++ b/drivers/net/ethernet/nebula-matrix/nbl/nbl_main.c
> @@ -0,0 +1,100 @@

[ ... ]

> +static int nbl_probe(struct pci_dev *pdev,
> +		     const struct pci_device_id *id)
> +{
> +	return -ENODEV;
> +}
> +
> +static void nbl_remove(struct pci_dev *pdev)
> +{
> +}

[ ... ]

> +	{ PCI_DEVICE(NBL_VENDOR_ID, NBL_DEVICE_ID_M18000_LX_BASE_T_OCP),
> +	  .driver_data = BIT(NBL_CAP_HAS_NET_BIT) },
> +	/* required as sentinel */
> +	{ }
> +};
> +MODULE_DEVICE_TABLE(pci, nbl_id_table);

[Severity: Low]
This isn't a bug either, just an observation about the intermediate state.
The full 16-entry nbl_id_table plus MODULE_DEVICE_TABLE(pci, nbl_id_table)
publishes udev autoload aliases for 1f0f:3403-3412 at a point where every
match is rejected:

  nbl_probe()
      return -ENODEV;

So a kernel built exactly at this commit with CONFIG_NBL=m will autoload
nbl on a present m18110/m18000 card and log a probe failure for each
matching function, with the device left unbound.  Nothing is allocated
before the -ENODEV return, so there is no leak, but it is visible during a
bisect of this series.

Would it be cleaner to add the id table (or the driver registration) in the
patch where nbl_probe() gains a working implementation, keeping every commit
in the series functional?

-- 
Sashiko AI review · https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20260914123429.56596-1-illusion.wang%40nebula-matrix.com