From: "tip-bot2 for Puranjay Mohan" <tip-bot2@linutronix.de>
To: linux-tip-commits@vger.kernel.org
Cc: Puranjay Mohan <puranjay@kernel.org>, Song Liu <song@kernel.org>,
Josh Poimboeuf <jpoimboe@kernel.org>,
x86@kernel.org, linux-kernel@vger.kernel.org
Subject: [tip: objtool/core] objtool/klp: Add test for newly introduced functions
Date: Fri, 18 Sep 2026 10:15:58 -0000 [thread overview]
Message-ID: <178972655899.1720534.17590896067712543850.tip-bot2@tip-bot2> (raw)
In-Reply-To: <20260916184351.2720310-15-song@kernel.org>
The following commit has been merged into the objtool/core branch of tip:
Commit-ID: 10aedc2ce2edc1a95e83da123ba76ea2eba07480
Gitweb: https://git.kernel.org/tip/10aedc2ce2edc1a95e83da123ba76ea2eba07480
Author: Puranjay Mohan <puranjay@kernel.org>
AuthorDate: Wed, 16 Sep 2026 11:43:07 -07:00
Committer: Josh Poimboeuf <jpoimboe@kernel.org>
CommitterDate: Wed, 16 Sep 2026 17:13:27 -07:00
objtool/klp: Add test for newly introduced functions
A function added by the patch has no original to correlate against, and
still has to be carried into the livepatch or the changed caller ends up
referencing something which does not exist.
The helper is noinline so the case survives the optimiser; otherwise the
compiler folds it into its only caller and the test covers nothing.
Signed-off-by: Puranjay Mohan <puranjay@kernel.org>
Assisted-by: Claude:claude-opus-5
Signed-off-by: Song Liu <song@kernel.org>
Link: https://patch.msgid.link/20260916184351.2720310-15-song@kernel.org
Signed-off-by: Josh Poimboeuf <jpoimboe@kernel.org>
---
tools/objtool/tests/generic/fixtures/new_function.c | 21 ++++++++++++-
tools/objtool/tests/generic/test-new-function.sh | 16 +++++++++-
2 files changed, 37 insertions(+)
create mode 100644 tools/objtool/tests/generic/fixtures/new_function.c
create mode 100755 tools/objtool/tests/generic/test-new-function.sh
diff --git a/tools/objtool/tests/generic/fixtures/new_function.c b/tools/objtool/tests/generic/fixtures/new_function.c
new file mode 100644
index 0000000..e7886ea
--- /dev/null
+++ b/tools/objtool/tests/generic/fixtures/new_function.c
@@ -0,0 +1,21 @@
+// SPDX-License-Identifier: GPL-2.0
+/* Function introduced by the patch. noinline keeps it from being folded. */
+
+static const char __modinfo[]
+ __attribute__((section(".modinfo"), used, aligned(1))) = "\0name=vmlinux";
+
+#ifdef PATCHED
+static __attribute__((noinline)) int klp_new_helper(int x)
+{
+ return x * 7;
+}
+#endif
+
+int target(int x)
+{
+#ifdef PATCHED
+ return klp_new_helper(x);
+#else
+ return x;
+#endif
+}
diff --git a/tools/objtool/tests/generic/test-new-function.sh b/tools/objtool/tests/generic/test-new-function.sh
new file mode 100755
index 0000000..b0b7f64
--- /dev/null
+++ b/tools/objtool/tests/generic/test-new-function.sh
@@ -0,0 +1,16 @@
+#!/bin/bash
+# SPDX-License-Identifier: GPL-2.0
+#
+# A function added by the patch has no original to correlate against and must
+# still be carried into the livepatch.
+
+. "$(dirname "$0")/../lib.sh"
+
+setup
+build_pair new_function.c
+run_diff
+
+assert_patched target
+assert_symbol klp_new_helper
+
+pass "new function carried into the patch with its caller"
next parent reply other threads:[~2026-09-18 10:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20260916184351.2720310-15-song@kernel.org>
2026-09-18 10:15 ` tip-bot2 for Puranjay Mohan [this message]
2026-09-21 9:28 ` tip-bot2 for Puranjay Mohan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=178972655899.1720534.17590896067712543850.tip-bot2@tip-bot2 \
--to=tip-bot2@linutronix.de \
--cc=jpoimboe@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=puranjay@kernel.org \
--cc=song@kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®