From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0CD39279DC2 for ; Mon, 15 Dec 2025 23:11:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765840307; cv=none; b=Ocfxemcc6Xzw/KwYXiqo/UDNlRuszLmNMWfxYfrdV9Ca9cqVp2B3nh9fWLYFZU7jfy4nARAy5K9Vj48saRI7p2ZXn/bVywk5NBVC/QJe6o4h59h0MkSzMOEV8xE1WsQIQmZ7MyDMJxnF03bwdSS7bAPp0BJE9a8nNNFGrwAaVaY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765840307; c=relaxed/simple; bh=9mOXI8QC1AqpHbGM6zt/JfJr3fh2o/pCGCDLcVW75h0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=goRl6sSySxEMTqDpIujfwmvnevr0W3a2vGaeYjGxRABg8mKc6LYIcWEgp5f5DEzvJE1p3jN+9btRYD3PGABCkky8xfvgpaJpIBCM3cN2LYuSA6X7T3Mdl0ep+uFjM9pkrN07vsR5JYv0v7zdwjlOU9mEraiOYyLkaJ1SlQSmfdo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=IZ52vt1O; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Ym0Cd0qW; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="IZ52vt1O"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Ym0Cd0qW" Received: from pps.filterd (m0279870.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BFI0RmO1682369 for ; Mon, 15 Dec 2025 23:11:45 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 9mOXI8QC1AqpHbGM6zt/JfJr3fh2o/pCGCDLcVW75h0=; b=IZ52vt1O7GbRGxZu lel5QAK0hybX00it8t69gxD0F7mnx4QPZ3B+kbXA/rI20xX1m9ErEW5R6pgQA4Uj wCJJj7udaLtcaKT4YO057G3vSTVIESUcl8OVV0WXsuhTzbqaA2owK7RHkKWb26yj jisMFLSZmsVzmC9SOrfkeNXPFHdF1I3lXfyyQUMVy1fndiLe77rNCOKYFtJewORX CQudnR5ELeWdRZwvBB1sxj1UucYCHx5BYqXgtDVDj/XWaRDR+TaQs2ZE5NKGDsV/ UJiWpVLrLYGCFuuWJ6xWNcLxj2UXfqyB6TDwFvmfN9hYPoAhEKQHWb46kvUHhw1v f5Ffdg== Received: from mail-pg1-f199.google.com (mail-pg1-f199.google.com [209.85.215.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4b2q7tgvxa-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 15 Dec 2025 23:11:44 +0000 (GMT) Received: by mail-pg1-f199.google.com with SMTP id 41be03b00d2f7-bdced916ad0so7201418a12.0 for ; Mon, 15 Dec 2025 15:11:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1765840304; x=1766445104; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=9mOXI8QC1AqpHbGM6zt/JfJr3fh2o/pCGCDLcVW75h0=; b=Ym0Cd0qWNqXYuqDahsMcitJ89Up9/5HwvSRnVItLnKnKg9X9vGYzCPX9FJrINeBWgJ JQKN2pY+g+ybf9wtutefelZIF6gzx9TJCQdDUfqMi+FdACmHzGSpxFA6o/jeP/Lme/9w zZqXGNNSGVPW3ShgQAqBTZ9y99WE0DGtAd90r7U+VJoODY1ePuekwCSRGE6ABDDryWcz DRYeM2JWtpn7iRyOWNpeLung6xF5BeT3CJegAyifser6KZP7BDO/pjIPf+HAWMcv3VwE RfayB0seXyl+oO3I035a8z/bW5mJoF06fo4+6cFwSZa+wkL0vItnBym2EW5PDrjXkpRW 3avg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765840304; x=1766445104; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=9mOXI8QC1AqpHbGM6zt/JfJr3fh2o/pCGCDLcVW75h0=; b=Stf5Z37zzvn8L2ymoSQOuiFpDfXg8UyntOzdW46qg/EQ6kmzOW8n3PvHvAPn9AqNLX 60QnKXPReJmI/hNWoAEh6B+p8GEnYbBxW7djkuXqZ8wVQNIIyMF5UdQFoPcvawsa5Kk0 rL5pcX6Ac6/oCkvrelTl/ogUfjJE143o/3JmRXhrN5GTwdmZhFk/YFEUIDCH0XaSzJmA /d1c6Im1BIxcPrdJh9R4OjHWqOONKnhEudinKjCmXBdIfFRvt5wJ1JPkOzmnCegMjB3P BUIuHosM4tC1YNlBuxK4Vmxwjlz3pvOS2E4fcVM4rmCkYm6XPUwIH1NIsT8BjjJkXWpZ M6xg== X-Forwarded-Encrypted: i=1; AJvYcCWXjB/wSR7WmRIoxFzlB8WMRba9lA4UIpptkvk5E0att1IcDg9X5cUUb8O1GKP0HwgvpBQUP0QIZ9zrehs=@vger.kernel.org X-Gm-Message-State: AOJu0Yw1M4N7Y10u4B0ovzzZdrSiE2VwVnwYeiiCUfCJ9O+N3ARGCwBy cUa76DIRYbzeJcbNWakGFhuUpWhOkzuuVBnewoOfR4Zn5zazmQOrmzs7zJsyyNBoeWlypdEN0sm ptmI8pV/2XT8Wjr6nb9kqpYNici8vSfOu96f/TMU220xr1vl+WlS0uA8/XlgGXopJsEU= X-Gm-Gg: AY/fxX5mm5fGI41jKtZAmHFvifLPGKqJOGcpCgRJ/4sYGwdZ6pexek4TifrF0PZI6db Wp2dQ0Rx0NNrRbjY0FLmjqospWPVpdtC/gNJkER0vWndWeYpiI+LklCdFUKammyLI96G66w1Ps7 oEkHgDDLw0khaFkwW6vbnjsqxzqHLtwhYrZb0cNg1L7Eb0hGHhGHYBkom+ffse7eC+gJz9OuiRy yJHFlCbkrN/+1qH2Ww1oWeBjiq+jiUAchVzhEchGJ5sN8+9WjZtXUgcwUaX48KwdtGRZKzJuD09 gX4e0lxhcNNGZmtXoUcICDAQ4Z6Py2EXwwDlhmJY3SldV+N3Dr8B9MGuWa8HNvVW6GvQa5At/vT A+fdMiXBoVLJQi7zIhVi3UmrBSjykmG5jmd6XPAqIrFOkCng1eDFPLWc09t5sQZjFsyaP8PHI0n U7 X-Received: by 2002:a05:693c:40d0:b0:2ac:2480:f0ac with SMTP id 5a478bee46e88-2ac300f6569mr7656637eec.23.1765840303801; Mon, 15 Dec 2025 15:11:43 -0800 (PST) X-Google-Smtp-Source: AGHT+IEGWd9bZdX9FqE4Zu9kudeOlBTu8WHuiZEe4iQU/7cEpax6mK1X2xvTe73Hi7niTXG2c7K7BA== X-Received: by 2002:a05:693c:40d0:b0:2ac:2480:f0ac with SMTP id 5a478bee46e88-2ac300f6569mr7656615eec.23.1765840303310; Mon, 15 Dec 2025 15:11:43 -0800 (PST) Received: from [192.168.1.3] (c-24-130-122-79.hsd1.ca.comcast.net. [24.130.122.79]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-11f43ced319sm15594685c88.9.2025.12.15.15.11.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 15 Dec 2025 15:11:43 -0800 (PST) Message-ID: <178f4564-8b59-4cf0-8274-dba7e58ba596@oss.qualcomm.com> Date: Mon, 15 Dec 2025 15:11:41 -0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/3] tee: qcomtee: call: Fix confusing cleanup.h syntax To: Sumit Garg , Krzysztof Kozlowski Cc: Amirreza Zarrabi , Jens Wiklander , linux-arm-msm@vger.kernel.org, op-tee@lists.trustedfirmware.org, linux-kernel@vger.kernel.org References: <20251208020844.5310-4-krzysztof.kozlowski@oss.qualcomm.com> From: Jeff Johnson Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: NZidBu85XAG7X3sgc3sDgiiH58fedZ_9 X-Proofpoint-ORIG-GUID: NZidBu85XAG7X3sgc3sDgiiH58fedZ_9 X-Authority-Analysis: v=2.4 cv=Qo1THFyd c=1 sm=1 tr=0 ts=694095b0 cx=c_pps a=Oh5Dbbf/trHjhBongsHeRQ==:117 a=Tg7Z00WN3eLgNEO9NLUKUQ==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=bC-a23v3AAAA:8 a=pGLkceISAAAA:8 a=AIc35tNdPba7fq3S6GQA:9 a=QEXdDO2ut3YA:10 a=_Vgx9l1VpLgwpw_dHYaR:22 a=FO4_E8m0qiDe52t0p3_H:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjE1MDIwMCBTYWx0ZWRfX/5Ms0HtqDhvu qcBi6sQSdrNQuEu76q17y8YGuivFoe5c9nxT52DyaXeRKoK8HwG+ATySnBhWQh8jJLgaqhwbDwi FFYzkkH50am5d2rF1r9tVhdZOwSwXTzFau+GIfXYHDg9EWWo27GR0ytlD8zyNCi3h8fXUDRz9c2 2wc9D290nnpqVXYXBpHsnT4tnrz7YzH4MatcuOS1ZJekesqBo/+Al8vHEE9C7qAEUon7+ggIqO5 T4ECgvbFkXnAgSljcC/LbWznTGfgeGZP1s4Vz2GctOB8hZqGfVfCwoyPUmJT3HWlv5Pz1xYtk0e nBakt4QqV0OyXcXhmtRRi2mT+Yx7dlBw0q8GvaRWyr+CB6ZF4Z2FLYtF+5EbmYyxsZUDGi5Mndg daRKlsSqIf0vOuacs3niMZt6fxVtAg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-15_05,2025-12-15_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 spamscore=0 adultscore=0 phishscore=0 bulkscore=0 clxscore=1015 lowpriorityscore=0 suspectscore=0 impostorscore=0 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510240001 definitions=main-2512150200 On 12/11/2025 5:39 PM, Sumit Garg wrote: > On Fri, Dec 12, 2025 at 02:07:40AM +0100, Krzysztof Kozlowski wrote: >> Sure, fair. I just don't get why introducing cleanup.h without actually >> accepting its explicitly documented style... > TBH, it is likely overlooked during review of the QTEE driver. Having a > builtin warning for the undesired syntax would help the reviewers here. It is in the works: https://patch.msgid.link/20251203-aheev-checkpatch-uninitialized-free-v7-1-841e3b31d8f3@gmail.com