Re: [PATCH net-next v5 2/3] dt-bindings: net: allwinner: add H616 EMAC1

[netdev-bot+sashiko@kernel.org]

Thank you for your contribution! Sashiko AI review found more severe
issue(s) in other patches of this series. This mail is only an FYI, in case
you want to address the nit picks below when you respin.

Low priority / nit picks for your consideration:

- [Low] Concern (validated as a FALSE POSITIVE in the series context):
  the patch documents `allwinner,sun50i-h616-emac1` in…

--

dt-bindings: net: allwinner: add H616 EMAC1

Adds the allwinner,sun50i-h616-emac1 compatible to the sun8i-a83t-emac
binding and to snps,dwmac.yaml, with no older fallback compatible, and
constrains phy-mode to rmii for that compatible.  It is also added to the
snps,dwmac.yaml list that excludes snps,tso.

> diff --git a/Documentation/devicetree/bindings/net/allwinner,sun8i-a83t-emac.yaml b/Documentation/devicetree/bindings/net/allwinner,sun8i-a83t-emac.yaml
> index 323a669fa9823..2cae0133b3cd4 100644
> --- a/Documentation/devicetree/bindings/net/allwinner,sun8i-a83t-emac.yaml
> +++ b/Documentation/devicetree/bindings/net/allwinner,sun8i-a83t-emac.yaml

[ ... ]

> @@ -33,6 +34,7 @@ properties:
>        - const: allwinner,sun8i-r40-gmac
>        - const: allwinner,sun8i-v3s-emac
>        - const: allwinner,sun50i-a64-emac
> +      - const: allwinner,sun50i-h616-emac1
>        - items:
>            - enum:
>                - allwinner,sun20i-d1-emac

[Severity: Low]
This isn't a bug, just a note for the record after checking it.

At this commit allwinner,sun50i-h616-emac1 has no match in the tree:

  git grep h616-emac1 drivers/net/ethernet/stmicro/stmmac/
  (no matches)

so a device tree node using only this compatible, with no older
fallback, validates but does not probe here.

The next and final patch in the series, "net: stmmac: sun8i: add support
for Allwinner H616 EMAC1", adds it to sun8i_dwmac_match[]:

  { .compatible = "allwinner,sun50i-h616-emac1",
    .data = &emac_variant_h616_emac1 },

and emac_variant_h616_emac1 uses sun8i_syscon_reg_field_emac1 with only
.support_rmii = true, which matches both the "separate system-control
clock register" statement in the changelog and the phy-mode: const: rmii
constraint added here.

Since bindings are expected to land before the driver, and the
intermediate state only leaves the compatible unmatched, there is
nothing to change.

[ ... ]

-- 
Sashiko AI review · https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20260921-submit-h616-emac1-v1-v5-0-ada661ed9e9b%40gmail.com