Re: [PATCH 1/2] Documentation: dsa: b53: fix stale tagging-support section

[netdev-bot+sashiko@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential
issue(s) to consider.

Critical: 0 · High: 0 · Medium: 1 · Low: 0

If you believe none of the issues are legitimate, please reply to each
issue of Medium severity or higher and explain why the AI is wrong.
If any of them are legitimate and you plan to respin, please let patchwork
know by including "pw-bot: cr" as a separate line at the end of your reply
(one such reply per series is enough).

- [Medium] The patch deletes the whole "Configuration without tagging
  support" section of Documentation/networking/dsa/b53.rst, including…

--

Documentation: dsa: b53: fix stale tagging-support section

This commit moves the 5325/5365 note into the tagging-supported section of
b53.rst, because b53_get_tag_protocol() gives them
DSA_TAG_PROTO_BRCM_LEGACY_FCS. It also deletes the whole "Configuration
without tagging support" section, including its single port, bridge and
gateway VLAN examples, on the grounds that it no longer applies to any b53
switch.

Link: https://patch.msgid.link/CAOiHx==_ixY-VNWX=XxqCFoJvE-80i+r2y6SNnxwQe9uZQJL6w@mail.gmail.com

> diff --git a/Documentation/networking/dsa/b53.rst b/Documentation/networking/dsa/b53.rst
> index 1cb3ff648f889..b67864b2d3144 100644
> --- a/Documentation/networking/dsa/b53.rst
> +++ b/Documentation/networking/dsa/b53.rst

[ ... ]

> @@ -35,149 +32,7 @@ Configuration with tagging support
>  The tagging based configuration is desired. It is not specific to the b53
>  DSA driver and will work like all DSA drivers which supports tagging.
>  
> -See :ref:`dsa-tagged-configuration`.
> -
> -Configuration without tagging support
> --------------------------------------
> -
> -Older models (5325, 5365) support a different tag format that is not supported
> -yet. 539x and 531x5 require managed mode and some special handling, which is
> -also not yet supported. The tagging support is disabled in these cases and the
> -switch need a different configuration.
> -
> -The configuration slightly differ from the :ref:`dsa-vlan-configuration`.
> -
> -The b53 tags the CPU port in all VLANs, since otherwise any PVID untagged
> -VLAN programming would basically change the CPU port's default PVID and make
> -it untagged, undesirable.

[Severity: Medium]

The commit message says:

  "The section and its config examples no longer apply to any b53 switch,
  so remove them."

Is that accurate? In drivers/net/dsa/b53/b53_common.c,
b53_get_tag_protocol() still falls back to DSA_TAG_PROTO_NONE for every
chip family. This check runs before any per-model tag selection:

	if (!b53_can_enable_brcm_tags(ds, port, mprot)) {
		dev->tag_protocol = DSA_TAG_PROTO_NONE;
		goto out;
	}

b53_can_enable_brcm_tags() returns false in two cases. The first is when
the CPU port is not 5, 7 or 8, which b53_possible_cpu_port() enforces. The
second is when the switch is stacked behind a Broadcom-tagging conduit:

	case DSA_TAG_PROTO_BRCM:
	case DSA_TAG_PROTO_BRCM_PREPEND:
		dev_warn(ds->dev,
			 "Port %d is stacked to Broadcom tag switch\n", port);
		ret = false;

In that mode the driver still behaves the way the removed text describes.
b53_vlan_port_needs_forced_tagged() keeps the CPU port tagged in all VLANs:

	return dev->tag_protocol == DSA_TAG_PROTO_NONE && dsa_is_cpu_port(ds, port);

and b53_vlan_setup() does this:

	ds->untag_bridge_pvid = dev->tag_protocol == DSA_TAG_PROTO_NONE;

After this patch, b53.rst only points to dsa-tagged-configuration. It no
longer mentions the untagged mode or links to dsa-vlan-configuration.
Boards whose CPU port is not 5/7/8 and cascaded Broadcom switches can
still end up in that mode.

Would it be better to keep this section and change the stated reason?
Tagging is disabled because of CPU port placement or stacking, not
because of the chip model (5325/5365/539x/531x5).

The follow-up patch in this series, "MAINTAINERS: add missing entry for
b53.rst", only adds an F: line and doesn't restore this content.

[ ... ]

> +Older models (5325, 5365) use a different, legacy tag format, but tagging
> +is supported.

[ ... ]

> +See :ref:`dsa-tagged-configuration`.

-- 
Sashiko AI review · https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20260922211439.369917-1-chrismelnu%40gmail.com