From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755560AbbJAL3V (ORCPT ); Thu, 1 Oct 2015 07:29:21 -0400 Received: from mout.kundenserver.de ([212.227.126.131]:58076 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753835AbbJAL3S (ORCPT ); Thu, 1 Oct 2015 07:29:18 -0400 From: Arnd Bergmann To: kbuild test robot Cc: Alim Akhtar , kbuild-all@01.org, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, JBottomley@odin.com, vinholikatti@gmail.com, amit.daniel@samsung.com, essuuj@gmail.com, devicetree@vger.kernel.org Subject: Re: [PATCH v3 13/13] scsi: ufs: Add exynos ufs platform data Date: Thu, 01 Oct 2015 13:29:10 +0200 Message-ID: <1790578.NZeHVGuJeN@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <201510011845.GN7Kisc4%fengguang.wu@intel.com> References: <201510011845.GN7Kisc4%fengguang.wu@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:yDWn/BDrG7CNSCGGXXDsb25L3a9mfuSOCHh7Iaf5ghwnQGc8NSi YaFnkPm5z9CSO7rM4DeQf0xwm1EGWZkfca1CHin6IcnhRCU60hW8xrkc/BFHCILAU6MW3Iy lSVqmkwrhoLpjjaBmpkQa2WyN1wkpcqUKFU98et1Q86Na0JeirbYX46NALvboyUFVXKg+o9 rcWh6FF3gNmxS6obFbqVg== X-UI-Out-Filterresults: notjunk:1;V01:K0:0dwWsNHN624=:9SYWyqzzcBWW10khp8RsHs xzQZl/823UEsFtIH/kv9etAYe+KRWZ1tMSJiRm2S+Bgg57U+rorxs9udEnVB90BclgMeebFF4 Olfl0bqOHgDHPV7RbasWLiUS/UYTiHJozPpI0DOig54/YQ/+5C6Q2LJZuwAQ8xEen5vq6NUYl LJPtcf6poC/9xduZigaDr+SHvRnOCvj8pDVVpZamNPib5QlwcRiYfgfxjmmsBprMRHL9Nf27h DL22itr1psyLisvSkNFhDOVepBpRLWUioPPhlUM50qtUiAg9yF52Iw1x5/nxcmT1g+u83azq7 r+rW40DVdHXR54klWOfS0Aib5vUo4W+zimVAvdrgrML3m/O1i/CaxJdCGG3FJs9/6EHzgrpnB co4HfFpQLtPiMrichKEfTsIJpsosbHb9RVf24vwA9LHahgIOdZhh6niqZ7hfuLJAyv6QvZvc8 Y2FckQGMIjTR1I8sSesiRkPrxBLVObcx3mKsVoAA6lsIcfHLge6QAph5Wat8pUlTrWtKvyA2g BL4NjtSlq+XFsdD+EJlwkOVuKZkDtJNEd9XesFdHr+0mQQOC7EFxTJ2PiDjNnQaJ2p2W5zjR8 yE4ouIu2TR/SfmJizoqadMgv7AfxeuwzbLZdduHwAIHiARTcPTmv2a6KSu0RV0Ym4PkyFRWtt 6eS0CfdAl+LhQt62+alKpUeTDVOuG4KexpQbG4RQ28V6lyjUEGnN508o4iiv5mG5SGPLFKmhl ilenxdYx5/uncSYk Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday 01 October 2015 18:46:34 kbuild test robot wrote: > [auto build test results on v4.3-rc3 -- if it's inappropriate base, please ignore] > > config: x86_64-allmodconfig (attached as .config) > reproduce: > git checkout 6e153e3bf7c68b019e987c5a0ffadebd9c7d4fbb > # save the attached .config to linux build tree > make ARCH=x86_64 > > All error/warnings (new ones prefixed by >>): > > >> ERROR: "ufs_hba_exynos_ops" [drivers/scsi/ufs/ufshcd-pltfrm.ko] undefined! > > Ah, this seems to be a case of layering violation. It would be best to restructure the code so that the exynos driver registers a platform_driver by itself for the respective DT compatible string, and then calls into the common code from its probe function, rather than having the generic driver know about the specific backends. That approach will also make the generic driver more scalable as we add further chip-specific variations, and matches what we do in other drivers. Arnd