From: Brian Masney <bmasney@redhat.com>
To: phucduc.bui@gmail.com
Cc: Emil Renner Berthing <kernel@esmil.dk>,
Hal Feng <hal.feng@starfivetech.com>,
Stephen Boyd <sboyd@kernel.org>,
Brian Masney <bmasney+clk@redhat.com>,
Jerome Brunet <jbrunet+clk@baylibre.com>,
Conor Dooley <conor.dooley@microchip.com>,
Palmer Dabbelt <palmer@rivosinc.com>,
Xingyu Wu <xingyu.wu@starfivetech.com>,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] clk: starfive: jh7110-isp: fix pm_runtime error handling
Date: Tue, 29 Sep 2026 13:11:06 -0400 [thread overview]
Message-ID: <179070186697.213266.8534133348671524620.b4-reply@b4> (raw)
In-Reply-To: <20260918050051.14986-1-phucduc.bui@gmail.com>
Hi bui,
On 2026-09-18 12:00 +0700, phucduc.bui@gmail.com wrote:
> From: bui duc phuc <phucduc.bui@gmail.com>
>
> pm_runtime_get_sync() leaves the runtime PM usage counter incremented even
> when it fails, but the error path in jh7110_ispcrg_probe() does not call
> pm_runtime_put_noidle() to balance it, leaking a reference each time
> resume fails.
>
> Use pm_runtime_resume_and_get() instead, which automatically drops the
> usage counter on failure, fixing the leak.
>
> Also disable runtime PM before returning from the error path to balance
> the pm_runtime_enable() call.
>
> Fixes: 81279f5d0812 ("clk: starfive: Add StarFive JH7110 Image-Signal-Process clock driver")
> Signed-off-by: bui duc phuc <phucduc.bui@gmail.com>
There's a separate fix for this that I applied earlier today.
Brian
prev parent reply other threads:[~2026-09-29 17:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-18 5:00 phucduc.bui
2026-09-29 17:11 ` Brian Masney [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=179070186697.213266.8534133348671524620.b4-reply@b4 \
--to=bmasney@redhat.com \
--cc=bmasney+clk@redhat.com \
--cc=conor.dooley@microchip.com \
--cc=hal.feng@starfivetech.com \
--cc=jbrunet+clk@baylibre.com \
--cc=kernel@esmil.dk \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=palmer@rivosinc.com \
--cc=phucduc.bui@gmail.com \
--cc=sboyd@kernel.org \
--cc=xingyu.wu@starfivetech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®