Re: [PATCH net 1/2] rxrpc: Fix the comments saying RFC8958 to be RFC8985

[netdev-bot+sashiko@kernel.org]

Thank you for your contribution! Sashiko AI review found more severe
issue(s) in other patches of this series. This mail is only an FYI, in case
you want to address the nit picks below when you respin.

Low priority / nit picks for your consideration:

- [Low] Commit "rxrpc: Fix the comments saying RFC8958 to be RFC8985"
  only changes comments.

--

rxrpc: Fix the comments saying RFC8958 to be RFC8985

This commit fixes comments in net/rxrpc/input_rack.c and
net/rxrpc/ar-internal.h that cited RFC8958 when they meant RFC8985, the
RACK-TLP loss detection algorithm for TCP. Only comments change. The
compiled output is the same.

> Fixes: 7c482665931b ("rxrpc: Implement RACK/TLP to deal with transmission stalls [RFC8985]")
> Signed-off-by: David Howells <dhowells@redhat.com>

[ ... ]

> cc: linux-afs@lists.infradead.org
> cc: stable@vger.kernel.org

[Severity: Low]
This isn't a bug, but should the stable Cc be here?

Each hunk swaps RFC8958 for RFC8985 in a comment, for example the file
header in input_rack.c:

-/* RACK-TLP [RFC8958] Implementation
+/* RACK-TLP [RFC8985] Implementation

Documentation/process/stable-kernel-rules.rst says:

  - No "trivial" fixes without benefit for users (spelling changes, whitespace
    cleanups, etc).

The Cc also doesn't seem needed as a prerequisite for the next patch in
the series, "rxrpc: Fix RACK-TLP implementation". That patch's hunks and
context lines don't touch any of the comments edited here. It changes
rxrpc_rack_mark_lost(), the bodies of rxrpc_rack_update_reo_wnd(),
rxrpc_rack_detect_loss() and rxrpc_tlp_calc_pto(), and the struct fields
under the "RACK-TLP [RFC8985] state" comment, which was already correct.
The functional fix should therefore apply cleanly without this patch.

Could the stable Cc be dropped, and would this patch fit better in
net-next than in net?

-- 
Sashiko AI review · https://netdev-ai.bots.linux.dev/sashiko/#/patchset/20260925191520.2206700-1-dhowells%40redhat.com