From: "Rob Herring (Arm)" <robh@kernel.org>
To: Yuho Choi <oss.patchbox@gmail.com>
Cc: devicetree@vger.kernel.org,
Saravana Kannan <saravanak@kernel.org>,
linux-kernel@vger.kernel.org,
Krzysztof Kozlowski <krzk@kernel.org>
Subject: Re: [PATCH v2] of: Put coreboot node after compatibility check
Date: Wed, 30 Sep 2026 16:03:40 -0500 [thread overview]
Message-ID: <179080221955.253092.2178461123666954664.robh@kernel.org> (raw)
In-Reply-To: <20260924011358.734722-1-oss.patchbox@gmail.com>
On Wed, 23 Sep 2026 21:13:50 -0400, Yuho Choi wrote:
> of_find_compatible_node() returns a referenced device node, but
> EXCLUDED_DEFAULT_CELLS_PLATFORMS used the result only as a boolean and
> discarded the reference. This leaked a reference each time the
> address-cells or size-cells warning condition was evaluated on a
> coreboot system.
>
> Use a helper that checks for the coreboot node with a scoped reference,
> so the reference is dropped once the check is done.
>
> Fixes: 8600058ba28a7 ("of: Add coreboot firmware to excluded default cells list")
> Signed-off-by: Yuho Choi <oss.patchbox@gmail.com>
> ---
> Changes in v2:
> - Use __free(device_node) in of_coreboot_present() (Krzysztof Kozlowski)
> - Switch to my oss.patchbox address
>
> v1: https://lore.kernel.org/all/20260802023821.494178-1-dbgh9129@gmail.com/
>
> drivers/of/base.c | 10 +++++++++-
> 1 file changed, 9 insertions(+), 1 deletion(-)
>
Applied, thanks!
prev parent reply other threads:[~2026-09-30 21:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-24 1:13 Yuho Choi
2026-09-30 21:03 ` Rob Herring (Arm) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=179080221955.253092.2178461123666954664.robh@kernel.org \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oss.patchbox@gmail.com \
--cc=saravanak@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®